realaravinth/bench-forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
bench-forgejo/cmd
History
Eng Zer Jun 8b0aaa5f86
test: use T.TempDir to create temporary test directory (#21043) 
A testing cleanup. 

This pull request replaces `os.MkdirTemp` with `t.TempDir`. We can use the `T.TempDir` function from the `testing` package to create temporary directory. The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. 

This saves us at least 2 lines (error check, and cleanup) on every instance, or in some cases adds cleanup that we forgot.

Reference: https://pkg.go.dev/testing#T.TempDir

```go
func TestFoo(t *testing.T) {
	// before
	tmpDir, err := os.MkdirTemp("", "")
	require.NoError(t, err)
	defer os.RemoveAll(tmpDir)

	// now
	tmpDir := t.TempDir()
}
```

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-09-04 16:14:53 +01:00
..
admin.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
admin_auth_ldap.go Allow enable LDAP source and disable user sync via CLI (#20206) 2022-07-04 11:21:14 +02:00
admin_auth_ldap_test.go Allow enable LDAP source and disable user sync via CLI (#20206) 2022-07-04 11:21:14 +02:00
cert.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
cmd.go fix: some typos (#19956) 2022-06-13 15:34:46 +08:00
convert.go Improve install code to avoid low-level mistakes. (#17779) 2021-12-01 15:50:01 +08:00
docs.go Fix offBy1 errors (#17606) 2021-11-14 10:11:49 +02:00
doctor.go Disable doctor logging on panic (#20847) 2022-08-18 21:27:27 -04:00
dump.go Add Tar ZSTD support (#20493) 2022-07-27 07:16:28 +01:00
dump_repo.go Make sure repo_dir is an empty directory or doesn't exist before 'dump-repo' (#20205) 2022-07-14 21:52:18 +08:00
embedded.go Share HTML template renderers and create a watcher framework (#20218) 2022-08-28 10:43:25 +01:00
embedded_stub.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
generate.go Add asymmetric JWT signing (#16010) 2021-06-17 23:56:46 +02:00
hook.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
hook_test.go Add agit flow support in gitea (#14295) 2021-07-28 17:42:56 +08:00
keys.go Second attempt at preventing zombies (#16326) 2021-07-14 10:43:13 -04:00
mailer.go Improve install code to avoid low-level mistakes. (#17779) 2021-12-01 15:50:01 +08:00
main_test.go Add migrate repo archiver and packages storage support on command line (#20757) 2022-08-16 12:05:15 +08:00
manager.go Fix various typos (#20338) 2022-07-12 23:32:37 +02:00
manager_logging.go Allow manager logging to set SQL (#20064) 2022-06-24 12:49:47 +02:00
migrate.go Improve install code to avoid low-level mistakes. (#17779) 2021-12-01 15:50:01 +08:00
migrate_storage.go fix hard-coded timeout and error panic in API archive download endpoint (#20925) 2022-08-29 11:45:20 +02:00
migrate_storage_test.go test: use T.TempDir to create temporary test directory (#21043) 2022-09-04 16:14:53 +01:00
restore_repo.go Fix cli command restore-repo: "units" should be splitted to string slice, to match the old behavior and match the dump-repo's behavior (#20183) 2022-07-01 15:47:44 +08:00
serv.go Move some code into models/git (#19879) 2022-06-12 23:51:54 +08:00
web.go Share HTML template renderers and create a watcher framework (#20218) 2022-08-28 10:43:25 +01:00
web_acme.go Support Proxy protocol (#12527) 2022-08-21 19:20:43 +01:00
web_graceful.go Support Proxy protocol (#12527) 2022-08-21 19:20:43 +01:00
web_https.go Support Proxy protocol (#12527) 2022-08-21 19:20:43 +01:00