bench-forgejo/models
M Hickford 191a74d622
Record OAuth client type at registration (#21316)
The OAuth spec [defines two types of
client](https://datatracker.ietf.org/doc/html/rfc6749#section-2.1),
confidential and public. Previously Gitea assumed all clients to be
confidential.

> OAuth defines two client types, based on their ability to authenticate
securely with the authorization server (i.e., ability to
>   maintain the confidentiality of their client credentials):
>
>   confidential
> Clients capable of maintaining the confidentiality of their
credentials (e.g., client implemented on a secure server with
> restricted access to the client credentials), or capable of secure
client authentication using other means.
>
>   **public
> Clients incapable of maintaining the confidentiality of their
credentials (e.g., clients executing on the device used by the resource
owner, such as an installed native application or a web browser-based
application), and incapable of secure client authentication via any
other means.**
>
> The client type designation is based on the authorization server's
definition of secure authentication and its acceptable exposure levels
of client credentials. The authorization server SHOULD NOT make
assumptions about the client type.

 https://datatracker.ietf.org/doc/html/rfc8252#section-8.4

> Authorization servers MUST record the client type in the client
registration details in order to identify and process requests
accordingly.

Require PKCE for public clients:
https://datatracker.ietf.org/doc/html/rfc8252#section-8.1

> Authorization servers SHOULD reject authorization requests from native
apps that don't use PKCE by returning an error message

Fixes #21299

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2022-10-24 15:59:24 +08:00
..
activities Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
admin Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
asymkey Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
auth Record OAuth client type at registration (#21316) 2022-10-24 15:59:24 +08:00
avatars Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
db Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
fixtures Record OAuth client type at registration (#21316) 2022-10-24 15:59:24 +08:00
foreignreference Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
git Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
issues Fix viewing user subscriptions (#21482) 2022-10-18 10:01:02 +02:00
migrations Record OAuth client type at registration (#21316) 2022-10-24 15:59:24 +08:00
organization Add team member invite by email (#20307) 2022-10-19 14:40:28 +02:00
packages Allow package version sorting (#21453) 2022-10-23 09:18:15 +08:00
perm Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
project Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
pull Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
repo Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
system Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
unit Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
unittest Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
user Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
webhook Decouple HookTask from Repository (#17940) 2022-10-21 18:21:56 +02:00
error.go Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
fixture_generation.go Move access and repo permission to models/perm/access (#19350) 2022-05-11 12:09:36 +02:00
fixture_test.go Decouple unit test code from business code (#17623) 2021-11-12 22:36:47 +08:00
main_test.go Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
migrate.go Add generic set type (#21408) 2022-10-12 13:18:26 +08:00
migrate_test.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
org.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
org_team.go Add team member invite by email (#20307) 2022-10-19 14:40:28 +02:00
org_team_test.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
org_test.go Refactor AssertExistsAndLoadBean to use generics (#20797) 2022-08-16 10:22:25 +08:00
repo.go Decouple HookTask from Repository (#17940) 2022-10-21 18:21:56 +02:00
repo_collaboration.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
repo_collaboration_test.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
repo_test.go Move tests as seperate sub packages to reduce duplicated file names (#19951) 2022-06-15 09:02:00 +02:00
repo_transfer.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
repo_transfer_test.go Refactor AssertExistsAndLoadBean to use generics (#20797) 2022-08-16 10:22:25 +08:00
user.go Fix delete user missed some comments (#21067) 2022-09-05 19:41:16 +03:00