realaravinth/bench-forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

markup: microoptimise for many short filenames in directory (#1534)

Browse source 
* markup: microoptimise for many short filenames in directory

Move strings.ToLower() after the early-return length check. This is a safe operation in all cases and should slightly improve directory listing performance when a directory contains many thousands of files with short filenames.

* markup: expand test cases for IsReadmeFile()
This commit is contained in:
mappu 2017-05-10 02:20:22 +12:00 committed by Lunny Xiao
parent d98a86d2a2
commit fd76f090a2
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
modules/markup/markup.go
View file

@ -71,11 +71,14 @@ func ReadmeFileType(name string) (string, bool) {
// IsReadmeFile reports whether name looks like a README file // IsReadmeFile reports whether name looks like a README file
// based on its name. // based on its name.
func IsReadmeFile(name string) bool { func IsReadmeFile(name string) bool {
name = strings.ToLower(name)
if len(name) < 6 { if len(name) < 6 {
return false return false
} else if len(name) == 6 { }
name = strings.ToLower(name)
if len(name) == 6 {
return name == "readme" return name == "readme"
} }
return name[:7] == "readme." return name[:7] == "readme."
} }

1
modules/markup/markup_test.go
View file

@ -25,6 +25,7 @@ func TestMisc_IsReadmeFile(t *testing.T) {
"abcdefg", "abcdefg",
"abcdefghijklmnopqrstuvwxyz", "abcdefghijklmnopqrstuvwxyz",
"test.md.test", "test.md.test",
"readmf",
} }
for _, testCase := range trueTestCases { for _, testCase := range trueTestCases {