realaravinth/bench-forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix U2F error reasons always hidden (#16327)

Browse source 
This strict equality check in `u2fError` was causing the error
description to hide immediately after showing. `Object.keys`
always returns strings, but `errorType` argument is usually a
number type.

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: zeripath <art27@cantab.net>
This commit is contained in:
Stephen Holdaway 2021-07-03 20:19:38 +12:00 committed by GitHub
parent a9ba29b1cd
commit f166f9b2e1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
web_src/js/index.js
View file

@ -2421,7 +2421,7 @@ function u2fError(errorType) {
u2fErrors[errorType].removeClass('hide'); u2fErrors[errorType].removeClass('hide');
Object.keys(u2fErrors).forEach((type) => { Object.keys(u2fErrors).forEach((type) => {
if (type !== errorType) { if (type !== `${errorType}`) {
u2fErrors[type].addClass('hide'); u2fErrors[type].addClass('hide');
} }
}); });