realaravinth/bench-forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Use node:16.5 for frontend instead of node:16 (#16591)

Browse source 
* Disable frontend testing

Jest does not appear to work on the latest node 16.6.0 and fails with an inscrutable
message.

I have been unable to work out what the problem is. This PR simply disables the
test-frontend part in the makefile.

Another alternative would be to drop node to node 14 - which is the LTS for node.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* actually just tell on 16.5 instead

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Use node 16.5 instead of 16

Signed-off-by: Andrew Thornton <art27@cantab.net>
This commit is contained in:
zeripath 2021-08-01 15:33:02 +01:00 committed by GitHub
parent b73e421646
commit e3b6526922
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
.drone.yml
View file

@ -15,12 +15,12 @@ trigger:
steps: steps:
- name: deps-frontend - name: deps-frontend
pull: always pull: always
image: node:16 image: node:16.5
commands: commands:
- make node_modules - make node_modules
- name: lint-frontend - name: lint-frontend
image: node:16 image: node:16.5
commands: commands:
- make lint-frontend - make lint-frontend
depends_on: [deps-frontend] depends_on: [deps-frontend]
@ -58,7 +58,7 @@ steps:
TAGS: bindata gogit sqlite sqlite_unlock_notify TAGS: bindata gogit sqlite sqlite_unlock_notify
- name: checks-frontend - name: checks-frontend
image: node:16 image: node:16.5
commands: commands:
- make checks-frontend - make checks-frontend
depends_on: [deps-frontend] depends_on: [deps-frontend]
@ -71,13 +71,13 @@ steps:
depends_on: [lint-backend] depends_on: [lint-backend]
- name: test-frontend - name: test-frontend
image: node:16 image: node:16.5
commands: commands:
- make test-frontend - make test-frontend
depends_on: [lint-frontend] depends_on: [lint-frontend]
- name: build-frontend - name: build-frontend
image: node:16 image: node:16.5
commands: commands:
- make frontend - make frontend
depends_on: [test-frontend] depends_on: [test-frontend]