realaravinth/bench-forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Better styling for code review comment form (#11413)

Browse source 
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
This commit is contained in:
Cirno the Strongest 2020-05-16 00:54:18 +02:00 committed by GitHub
parent db87e91227
commit c483419184
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
templates/repo/diff/section_unified.tmpl
View file

@ -28,8 +28,7 @@
{{$isNotPending := (not (eq (index $line.Comments 0).Review.Type 0))}} {{$isNotPending := (not (eq (index $line.Comments 0).Review.Type 0))}}
<tr> <tr>
<td colspan="2" class="lines-num"></td> <td colspan="2" class="lines-num"></td>
<td class="lines-type-marker"></td> <td class="add-comment-left add-comment-right" colspan="2">
<td class="add-comment-left add-comment-right">
{{if $resolved}} {{if $resolved}}
<div class = "ui attached header"> <div class = "ui attached header">
<span class="ui grey text left"><b>{{$resolveDoer.Name}}</b> {{$.root.i18n.Tr "repo.issues.review.resolved_by"}}</span> <span class="ui grey text left"><b>{{$resolveDoer.Name}}</b> {{$.root.i18n.Tr "repo.issues.review.resolved_by"}}</span>

2
web_src/js/index.js
View file

@ -1242,7 +1242,7 @@ function initPullRequestReview() {
if (!ntr.hasClass('add-comment')) { if (!ntr.hasClass('add-comment')) {
ntr = $(`<tr class="add-comment">${ ntr = $(`<tr class="add-comment">${
isSplit ? '<td class="lines-num"></td><td class="lines-type-marker"></td><td class="add-comment-left"></td><td class="lines-num"></td><td class="lines-type-marker"></td><td class="add-comment-right"></td>' : isSplit ? '<td class="lines-num"></td><td class="lines-type-marker"></td><td class="add-comment-left"></td><td class="lines-num"></td><td class="lines-type-marker"></td><td class="add-comment-right"></td>' :
'<td class="lines-num"></td><td class="lines-num"></td><td class="lines-type-marker"></td><td class="add-comment-left add-comment-right"></td>' '<td class="lines-num"></td><td class="lines-num"></td><td class="add-comment-left add-comment-right" colspan="2"></td>'
}</tr>`); }</tr>`);
tr.after(ntr); tr.after(ntr);
} }

8
web_src/less/_review.less
View file

@ -74,9 +74,13 @@
margin-top: 0; margin-top: 0;
} }
.comment-list {
padding-bottom: 10px;
}
.footer { .footer {
border-top: 1px solid #f1f1f1; border-top: 1px solid #f1f1f1;
margin-top: 10px; padding: 10px 0 10px 0;
.markdown-info { .markdown-info {
display: inline-block; display: inline-block;
@ -101,7 +105,7 @@
} }
form.comment-form-reply { form.comment-form-reply {
margin: 0 0 0 4em; margin: 0 0 0 1em;
} }
} }