realaravinth/bench-forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix bug when read public repo lfs file (#5912)

Browse source 
* fix bug when read public repo lfs file

* add comment on lfs permission check
This commit is contained in:
Lunny Xiao 2019-01-31 21:36:57 +08:00 committed by zeripath
parent 0823791d17
commit bbad9b6178
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
modules/lfs/server.go
View file

@ -497,12 +497,15 @@ func authenticate(ctx *context.Context, repository *models.Repository, authoriza
accessMode = models.AccessModeWrite accessMode = models.AccessModeWrite
} }
// ctx.IsSigned is unnecessary here, this will be checked in perm.CanAccess
perm, err := models.GetUserRepoPermission(repository, ctx.User) perm, err := models.GetUserRepoPermission(repository, ctx.User)
if err != nil { if err != nil {
return false return false
} }
if ctx.IsSigned {
return perm.CanAccess(accessMode, models.UnitTypeCode) canRead := perm.CanAccess(accessMode, models.UnitTypeCode)
if canRead {
return true
} }
user, repo, opStr, err := parseToken(authorization) user, repo, opStr, err := parseToken(authorization)