realaravinth/bench-forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Use a common quote to instead of check database type (#16817)

Browse source 
`` ` `` will be converted to different database quote by xorm. So check database type is unnecessary.
This commit is contained in:
Lunny Xiao 2021-08-25 20:23:34 +08:00 committed by GitHub
parent 697213bdb3
commit b88dbe1208
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
models/user.go
View file

@ -1619,14 +1619,7 @@ func (opts *SearchUserOptions) toConds() builder.Cond {
} }
if opts.Actor != nil { if opts.Actor != nil {
var exprCond builder.Cond var exprCond builder.Cond = builder.Expr("org_user.org_id = `user`.id")
if setting.Database.UseMySQL {
exprCond = builder.Expr("org_user.org_id = user.id")
} else if setting.Database.UseMSSQL {
exprCond = builder.Expr("org_user.org_id = [user].id")
} else {
exprCond = builder.Expr("org_user.org_id = \"user\".id")
}
// If Admin - they see all users! // If Admin - they see all users!
if !opts.Actor.IsAdmin { if !opts.Actor.IsAdmin {