realaravinth/bench-forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fixed ineffectual assignments (#7555)

Browse source 
Don't assign values we never use.
This commit is contained in:
Christian Muehlhaeuser 2019-07-22 11:35:54 +02:00 committed by Lunny Xiao
parent 9a965035f0
commit b0cd3b8ab9
2 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
models/git_diff.go
View file

@ -543,7 +543,7 @@ func ParsePatch(maxLines, maxLineCharacters, maxFiles int, reader io.Reader) (*D
// Get new file. // Get new file.
if strings.HasPrefix(line, cmdDiffHead) { if strings.HasPrefix(line, cmdDiffHead) {
middle := -1 var middle int
// Note: In case file name is surrounded by double quotes (it happens only in git-shell). // Note: In case file name is surrounded by double quotes (it happens only in git-shell).
// e.g. diff --git "a/xxx" "b/xxx" // e.g. diff --git "a/xxx" "b/xxx"

1
routers/user/setting/security_twofa.go
View file

@ -81,7 +81,6 @@ func twofaGenerateSecretAndQr(ctx *context.Context) bool {
// Filter unsafe character ':' in issuer // Filter unsafe character ':' in issuer
issuer := strings.Replace(setting.AppName+" ("+setting.Domain+")", ":", "", -1) issuer := strings.Replace(setting.AppName+" ("+setting.Domain+")", ":", "", -1)
if otpKey == nil { if otpKey == nil {
err = nil // clear the error, in case the URL was invalid
otpKey, err = totp.Generate(totp.GenerateOpts{ otpKey, err = totp.Generate(totp.GenerateOpts{
SecretSize: 40, SecretSize: 40,
Issuer: issuer, Issuer: issuer,