realaravinth/bench-forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

refactor api issues load attributes for better performance (#1066)

Browse source
This commit is contained in:
Lunny Xiao 2017-02-27 08:36:42 +08:00 committed by GitHub
parent ab462fb95f
commit a5ac4c64fc
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
routers/api/v1/repo/issue.go
View file

@ -40,13 +40,14 @@ func ListIssues(ctx *context.APIContext) {
issues = append(issues, tempIssues...) issues = append(issues, tempIssues...)
} }
// FIXME: use IssueList to improve performance. err = models.IssueList(issues).LoadAttributes()
apiIssues := make([]*api.Issue, len(issues)) if err != nil {
for i := range issues {
if err = issues[i].LoadAttributes(); err != nil {
ctx.Error(500, "LoadAttributes", err) ctx.Error(500, "LoadAttributes", err)
return return
} }
apiIssues := make([]*api.Issue, len(issues))
for i := range issues {
apiIssues[i] = issues[i].APIFormat() apiIssues[i] = issues[i].APIFormat()
} }