CONTRIBUTING.md: link to "Faster reviews" document (#229)
* CONTRIBUTING.md: link to "Faster reviews" document * CONTRIBUTING.md: small fixes
This commit is contained in:
parent
21e8deed89
commit
6a28909f40
1 changed files with 13 additions and 0 deletions
|
@ -76,6 +76,19 @@ who makes the change even if an owners or a maintainer. We use github's
|
||||||
pull request workflow to do that and use [lgtm](http://lgtm.co) to ensure
|
pull request workflow to do that and use [lgtm](http://lgtm.co) to ensure
|
||||||
every PR is reviewed by at least 2 maintainers.
|
every PR is reviewed by at least 2 maintainers.
|
||||||
|
|
||||||
|
Please try to make your pull request easy to review for us. Please read the
|
||||||
|
["How to get faster PR reviews"](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md),
|
||||||
|
guide, it got useful tips for any project you may want to contribute. See some
|
||||||
|
of the points:
|
||||||
|
|
||||||
|
- Make small pull requests. The smaller, the faster to review and the more
|
||||||
|
likely it will be merged soon.
|
||||||
|
- Don't make changes unrelated to your PR. Maybe there are typos on some
|
||||||
|
comments, maybe refactoring would welcome on a function... but if that is not
|
||||||
|
related to you PR, please make *another* PR for that.
|
||||||
|
- Split big pull requests in multiple. An incremental change will be faster to
|
||||||
|
review than a huge PR.
|
||||||
|
|
||||||
## Sign your work
|
## Sign your work
|
||||||
|
|
||||||
The sign-off is a simple line at the end of the explanation for the
|
The sign-off is a simple line at the end of the explanation for the
|
||||||
|
|
Loading…
Reference in a new issue