realaravinth/bench-forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Properly escape release attachment URL (#6512)

Browse source 
Make sure file attachments on a release get a properly escaped URL when
linking.

Fixes #6506
This commit is contained in:
mrsdizzie 2019-04-05 11:28:10 -04:00 committed by techknowlogick
parent 9bf20f47c4
commit 0bdd81df9d
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
templates/repo/release/list.tmpl
View file

@ -77,7 +77,7 @@
{{if .Attachments}} {{if .Attachments}}
{{range $attachment := .Attachments}} {{range $attachment := .Attachments}}
<li> <li>
<a target="_blank" rel="noopener noreferrer" href="{{$.RepoLink}}/releases/download/{{$release.TagName}}/{{$attachment.Name}}"> <a target="_blank" rel="noopener noreferrer" href="{{$.RepoLink}}/releases/download/{{$release.TagName | PathEscape}}/{{$attachment.Name | PathEscape}}">
<strong><span class="ui image octicon octicon-package" title='{{$attachment.Name}}'></span> {{$attachment.Name}}</strong> <strong><span class="ui image octicon octicon-package" title='{{$attachment.Name}}'></span> {{$attachment.Name}}</strong>
<span class="ui text grey right">{{$attachment.Size | FileSize}}</span> <span class="ui text grey right">{{$attachment.Size | FileSize}}</span>
</a> </a>