realaravinth/bench-forgejo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix login with email for ldap users (#18800)

Browse source 
`authenticator.Authenticate` has assume the login name is not an email, but `username` maybe an email. So when we find the user via email address, we should use `user.LoginName` instead of `username` which is an email address.
This commit is contained in:
Lunny Xiao 2022-02-20 18:28:58 +08:00 committed by GitHub
parent d5a4c5530a
commit 00be0c1b21
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/auth/signin.go
View file

@ -65,7 +65,7 @@ func UserSignIn(username, password string) (*user_model.User, *auth.Source, erro
return nil, nil, smtp.ErrUnsupportedLoginType return nil, nil, smtp.ErrUnsupportedLoginType
} }
user, err := authenticator.Authenticate(user, username, password) user, err := authenticator.Authenticate(user, user.LoginName, password)
if err != nil { if err != nil {
return nil, nil, err return nil, nil, err
} }