2019-05-07 06:42:51 +05:30
// Copyright 2019 The Gitea Authors. All rights reserved.
// Copyright 2018 Jonas Franz. All rights reserved.
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.
package migrations
import (
2020-09-02 23:19:25 +05:30
"context"
2020-01-16 20:45:44 +05:30
"os"
2019-05-07 06:42:51 +05:30
"testing"
"time"
2021-11-16 20:55:33 +05:30
base "code.gitea.io/gitea/modules/migration"
2019-05-07 06:42:51 +05:30
"github.com/stretchr/testify/assert"
)
func TestGitHubDownloadRepo ( t * testing . T ) {
2022-01-05 11:57:53 +05:30
GithubLimitRateRemaining = 3 // Wait at 3 remaining since we could have 3 CI in //
2020-09-21 20:06:51 +05:30
downloader := NewGithubDownloaderV3 ( context . Background ( ) , "https://github.com" , "" , "" , os . Getenv ( "GITHUB_READ_TOKEN" ) , "go-gitea" , "test_repo" )
2020-01-16 20:45:44 +05:30
err := downloader . RefreshRate ( )
assert . NoError ( t , err )
2019-05-07 06:42:51 +05:30
repo , err := downloader . GetRepoInfo ( )
assert . NoError ( t , err )
2021-08-18 06:17:18 +05:30
assertRepositoryEqual ( t , & base . Repository {
2020-09-15 20:07:44 +05:30
Name : "test_repo" ,
Owner : "go-gitea" ,
Description : "Test repository for testing migration from github to gitea" ,
CloneURL : "https://github.com/go-gitea/test_repo.git" ,
OriginalURL : "https://github.com/go-gitea/test_repo" ,
DefaultBranch : "master" ,
2019-05-07 06:42:51 +05:30
} , repo )
2019-08-14 11:46:12 +05:30
topics , err := downloader . GetTopics ( )
assert . NoError ( t , err )
assert . Contains ( t , topics , "gitea" )
2019-05-07 06:42:51 +05:30
milestones , err := downloader . GetMilestones ( )
assert . NoError ( t , err )
2021-08-18 06:17:18 +05:30
assertMilestonesEqual ( t , [ ] * base . Milestone {
{
Title : "1.0.0" ,
Description : "Milestone 1.0.0" ,
Deadline : timePtr ( time . Date ( 2019 , 11 , 11 , 8 , 0 , 0 , 0 , time . UTC ) ) ,
Created : time . Date ( 2019 , 11 , 12 , 19 , 37 , 8 , 0 , time . UTC ) ,
Updated : timePtr ( time . Date ( 2019 , 11 , 12 , 21 , 56 , 17 , 0 , time . UTC ) ) ,
Closed : timePtr ( time . Date ( 2019 , 11 , 12 , 19 , 45 , 49 , 0 , time . UTC ) ) ,
State : "closed" ,
} ,
{
Title : "1.1.0" ,
Description : "Milestone 1.1.0" ,
Deadline : timePtr ( time . Date ( 2019 , 11 , 12 , 8 , 0 , 0 , 0 , time . UTC ) ) ,
Created : time . Date ( 2019 , 11 , 12 , 19 , 37 , 25 , 0 , time . UTC ) ,
Updated : timePtr ( time . Date ( 2019 , 11 , 12 , 21 , 39 , 27 , 0 , time . UTC ) ) ,
Closed : timePtr ( time . Date ( 2019 , 11 , 12 , 19 , 45 , 46 , 0 , time . UTC ) ) ,
State : "closed" ,
} ,
} , milestones )
2019-05-07 06:42:51 +05:30
labels , err := downloader . GetLabels ( )
assert . NoError ( t , err )
2021-08-18 06:17:18 +05:30
assertLabelsEqual ( t , [ ] * base . Label {
{
Name : "bug" ,
Color : "d73a4a" ,
Description : "Something isn't working" ,
} ,
{
Name : "documentation" ,
Color : "0075ca" ,
Description : "Improvements or additions to documentation" ,
} ,
{
Name : "duplicate" ,
Color : "cfd3d7" ,
Description : "This issue or pull request already exists" ,
} ,
{
Name : "enhancement" ,
Color : "a2eeef" ,
Description : "New feature or request" ,
} ,
{
Name : "good first issue" ,
Color : "7057ff" ,
Description : "Good for newcomers" ,
} ,
{
Name : "help wanted" ,
Color : "008672" ,
Description : "Extra attention is needed" ,
} ,
{
Name : "invalid" ,
Color : "e4e669" ,
Description : "This doesn't seem right" ,
} ,
{
Name : "question" ,
Color : "d876e3" ,
Description : "Further information is requested" ,
} ,
{
Name : "wontfix" ,
Color : "ffffff" ,
Description : "This will not be worked on" ,
} ,
} , labels )
2019-05-07 06:42:51 +05:30
releases , err := downloader . GetReleases ( )
assert . NoError ( t , err )
2021-08-18 06:17:18 +05:30
assertReleasesEqual ( t , [ ] * base . Release {
2019-05-07 06:42:51 +05:30
{
TagName : "v0.9.99" ,
TargetCommitish : "master" ,
2019-11-13 04:18:21 +05:30
Name : "First Release" ,
Body : "A test release" ,
Created : time . Date ( 2019 , 11 , 9 , 16 , 49 , 21 , 0 , time . UTC ) ,
Published : time . Date ( 2019 , 11 , 12 , 20 , 12 , 10 , 0 , time . UTC ) ,
PublisherID : 1669571 ,
PublisherName : "mrsdizzie" ,
2019-05-07 06:42:51 +05:30
} ,
2021-08-18 06:17:18 +05:30
} , releases )
2019-05-07 06:42:51 +05:30
// downloader.GetIssues()
2019-11-13 04:18:21 +05:30
issues , isEnd , err := downloader . GetIssues ( 1 , 2 )
2019-05-07 06:42:51 +05:30
assert . NoError ( t , err )
2019-05-31 01:56:57 +05:30
assert . False ( t , isEnd )
2021-08-18 06:17:18 +05:30
assertIssuesEqual ( t , [ ] * base . Issue {
2019-05-07 06:42:51 +05:30
{
2019-11-13 04:18:21 +05:30
Number : 1 ,
Title : "Please add an animated gif icon to the merge button" ,
Content : "I just want the merge button to hurt my eyes a little. \xF0\x9F\x98\x9D " ,
Milestone : "1.0.0" ,
PosterID : 18600385 ,
PosterName : "guillep2k" ,
2019-05-07 06:42:51 +05:30
State : "closed" ,
2019-11-13 04:18:21 +05:30
Created : time . Date ( 2019 , 11 , 9 , 17 , 0 , 29 , 0 , time . UTC ) ,
2020-01-14 15:59:22 +05:30
Updated : time . Date ( 2019 , 11 , 12 , 20 , 29 , 53 , 0 , time . UTC ) ,
2019-05-07 06:42:51 +05:30
Labels : [ ] * base . Label {
{
2019-11-13 04:18:21 +05:30
Name : "bug" ,
Color : "d73a4a" ,
Description : "Something isn't working" ,
2019-05-07 06:42:51 +05:30
} ,
{
2019-11-13 04:18:21 +05:30
Name : "good first issue" ,
Color : "7057ff" ,
Description : "Good for newcomers" ,
2019-05-07 06:42:51 +05:30
} ,
} ,
2020-01-15 16:44:07 +05:30
Reactions : [ ] * base . Reaction {
{
UserID : 1669571 ,
UserName : "mrsdizzie" ,
Content : "+1" ,
} ,
2019-05-07 06:42:51 +05:30
} ,
2021-08-18 06:17:18 +05:30
Closed : timePtr ( time . Date ( 2019 , 11 , 12 , 20 , 22 , 22 , 0 , time . UTC ) ) ,
2019-05-07 06:42:51 +05:30
} ,
{
2019-11-13 04:18:21 +05:30
Number : 2 ,
Title : "Test issue" ,
Content : "This is test issue 2, do not touch!" ,
Milestone : "1.1.0" ,
PosterID : 1669571 ,
PosterName : "mrsdizzie" ,
2019-07-08 15:40:56 +05:30
State : "closed" ,
2019-11-13 04:18:21 +05:30
Created : time . Date ( 2019 , 11 , 12 , 21 , 0 , 6 , 0 , time . UTC ) ,
2020-01-14 15:59:22 +05:30
Updated : time . Date ( 2019 , 11 , 12 , 22 , 7 , 14 , 0 , time . UTC ) ,
2019-05-07 06:42:51 +05:30
Labels : [ ] * base . Label {
{
2019-11-13 04:18:21 +05:30
Name : "duplicate" ,
Color : "cfd3d7" ,
Description : "This issue or pull request already exists" ,
2019-05-07 06:42:51 +05:30
} ,
} ,
2020-01-15 16:44:07 +05:30
Reactions : [ ] * base . Reaction {
{
UserID : 1669571 ,
UserName : "mrsdizzie" ,
Content : "heart" ,
} ,
{
UserID : 1669571 ,
UserName : "mrsdizzie" ,
Content : "laugh" ,
} ,
{
UserID : 1669571 ,
UserName : "mrsdizzie" ,
Content : "-1" ,
} ,
{
UserID : 1669571 ,
UserName : "mrsdizzie" ,
Content : "confused" ,
} ,
{
UserID : 1669571 ,
UserName : "mrsdizzie" ,
Content : "hooray" ,
} ,
{
UserID : 1669571 ,
UserName : "mrsdizzie" ,
Content : "+1" ,
} ,
2019-05-07 06:42:51 +05:30
} ,
2021-08-18 06:17:18 +05:30
Closed : timePtr ( time . Date ( 2019 , 11 , 12 , 21 , 1 , 31 , 0 , time . UTC ) ) ,
2019-05-07 06:42:51 +05:30
} ,
} , issues )
// downloader.GetComments()
Store the foreign ID of issues during migration (#18446)
Storing the foreign identifier of an imported issue in the database is a prerequisite to implement idempotent migrations or mirror for issues. It is a baby step towards mirroring that introduces a new table.
At the moment when an issue is created by the Gitea uploader, it fails if the issue already exists. The Gitea uploader could be modified so that, instead of failing, it looks up the database to find an existing issue. And if it does it would update the issue instead of creating a new one. However this is not currently possible because an information is missing from the database: the foreign identifier that uniquely represents the issue being migrated is not persisted. With this change, the foreign identifier is stored in the database and the Gitea uploader will then be able to run a query to figure out if a given issue being imported already exists.
The implementation of mirroring for issues, pull requests, releases, etc. can be done in three steps:
1. Store an identifier for the element being mirrored (issue, pull request...) in the database (this is the purpose of these changes)
2. Modify the Gitea uploader to be able to update an existing repository with all it contains (issues, pull request...) instead of failing if it exists
3. Optimize the Gitea uploader to speed up the updates, when possible.
The second step creates code that does not yet exist to enable idempotent migrations with the Gitea uploader. When a migration is done for the first time, the behavior is not changed. But when a migration is done for a repository that already exists, this new code is used to update it.
The third step can use the code created in the second step to optimize and speed up migrations. For instance, when a migration is resumed, an issue that has an update time that is not more recent can be skipped and only newly created issues or updated ones will be updated. Another example of optimization could be that a webhook notifies Gitea when an issue is updated. The code triggered by the webhook would download only this issue and call the code created in the second step to update the issue, as if it was in the process of an idempotent migration.
The ForeignReferences table is added to contain local and foreign ID pairs relative to a given repository. It can later be used for pull requests and other artifacts that can be mirrored. Although the foreign id could be added as a single field in issues or pull requests, it would need to be added to all tables that represent something that can be mirrored. Creating a new table makes for a simpler and more generic design. The drawback is that it requires an extra lookup to obtain the information. However, this extra information is only required during migration or mirroring and does not impact the way Gitea currently works.
The foreign identifier of an issue or pull request is similar to the identifier of an external user, which is stored in reactions, issues, etc. as OriginalPosterID and so on. The representation of a user is however different and the ability of users to link their account to an external user at a later time is also a logic that is different from what is involved in mirroring or migrations. For these reasons, despite some commonalities, it is unclear at this time how the two tables (foreign reference and external user) could be merged together.
The ForeignID field is extracted from the issue migration context so that it can be dumped in files with dump-repo and later restored via restore-repo.
The GetAllComments downloader method is introduced to simplify the implementation and not overload the Context for the purpose of pagination. It also clarifies in which context the comments are paginated and in which context they are not.
The Context interface is no longer useful for the purpose of retrieving the LocalID and ForeignID since they are now both available from the PullRequest and Issue struct. The Reviewable and Commentable interfaces replace and serve the same purpose.
The Context data member of PullRequest and Issue becomes a DownloaderContext to clarify that its purpose is not to support in memory operations while the current downloader is acting but is not otherwise persisted. It is, for instance, used by the GitLab downloader to store the IsMergeRequest boolean and sort out issues.
---
[source](https://lab.forgefriends.org/forgefriends/forgefriends/-/merge_requests/36)
Signed-off-by: Loïc Dachary <loic@dachary.org>
Co-authored-by: Loïc Dachary <loic@dachary.org>
2022-03-17 22:38:35 +05:30
comments , _ , err := downloader . GetComments ( & base . Issue { Number : 2 , ForeignIndex : 2 } )
2019-05-07 06:42:51 +05:30
assert . NoError ( t , err )
2021-08-18 06:17:18 +05:30
assertCommentsEqual ( t , [ ] * base . Comment {
2019-05-07 06:42:51 +05:30
{
2019-11-13 04:18:21 +05:30
IssueIndex : 2 ,
PosterID : 1669571 ,
PosterName : "mrsdizzie" ,
Created : time . Date ( 2019 , 11 , 12 , 21 , 0 , 13 , 0 , time . UTC ) ,
2020-01-14 15:59:22 +05:30
Updated : time . Date ( 2019 , 11 , 12 , 21 , 0 , 13 , 0 , time . UTC ) ,
2019-11-13 04:18:21 +05:30
Content : "This is a comment" ,
2020-01-15 16:44:07 +05:30
Reactions : [ ] * base . Reaction {
{
UserID : 1669571 ,
UserName : "mrsdizzie" ,
Content : "+1" ,
} ,
2019-05-07 06:42:51 +05:30
} ,
} ,
{
2019-11-13 04:18:21 +05:30
IssueIndex : 2 ,
PosterID : 1669571 ,
PosterName : "mrsdizzie" ,
Created : time . Date ( 2019 , 11 , 12 , 22 , 7 , 14 , 0 , time . UTC ) ,
2020-01-14 15:59:22 +05:30
Updated : time . Date ( 2019 , 11 , 12 , 22 , 7 , 14 , 0 , time . UTC ) ,
2019-11-13 04:18:21 +05:30
Content : "A second comment" ,
2020-01-15 16:44:07 +05:30
Reactions : nil ,
2019-05-07 06:42:51 +05:30
} ,
2021-08-18 06:17:18 +05:30
} , comments )
2019-05-07 06:42:51 +05:30
// downloader.GetPullRequests()
2020-10-14 09:36:00 +05:30
prs , _ , err := downloader . GetPullRequests ( 1 , 2 )
2019-05-07 06:42:51 +05:30
assert . NoError ( t , err )
2021-08-18 06:17:18 +05:30
assertPullRequestsEqual ( t , [ ] * base . PullRequest {
2019-05-07 06:42:51 +05:30
{
2019-11-13 04:18:21 +05:30
Number : 3 ,
Title : "Update README.md" ,
Content : "add warning to readme" ,
Milestone : "1.1.0" ,
PosterID : 1669571 ,
PosterName : "mrsdizzie" ,
2019-05-07 06:42:51 +05:30
State : "closed" ,
2019-11-13 04:18:21 +05:30
Created : time . Date ( 2019 , 11 , 12 , 21 , 21 , 43 , 0 , time . UTC ) ,
2020-01-14 15:59:22 +05:30
Updated : time . Date ( 2019 , 11 , 12 , 21 , 39 , 28 , 0 , time . UTC ) ,
2019-05-07 06:42:51 +05:30
Labels : [ ] * base . Label {
{
2019-11-13 04:18:21 +05:30
Name : "documentation" ,
Color : "0075ca" ,
Description : "Improvements or additions to documentation" ,
2019-05-07 06:42:51 +05:30
} ,
} ,
2019-11-13 04:18:21 +05:30
PatchURL : "https://github.com/go-gitea/test_repo/pull/3.patch" ,
2019-05-07 06:42:51 +05:30
Head : base . PullRequestBranch {
2019-11-13 04:18:21 +05:30
Ref : "master" ,
CloneURL : "https://github.com/mrsdizzie/test_repo.git" ,
SHA : "076160cf0b039f13e5eff19619932d181269414b" ,
RepoName : "test_repo" ,
OwnerName : "mrsdizzie" ,
2019-05-07 06:42:51 +05:30
} ,
Base : base . PullRequestBranch {
Ref : "master" ,
2019-11-13 04:18:21 +05:30
SHA : "72866af952e98d02a73003501836074b286a78f6" ,
2019-05-07 06:42:51 +05:30
OwnerName : "go-gitea" ,
2019-11-13 04:18:21 +05:30
RepoName : "test_repo" ,
2019-05-07 06:42:51 +05:30
} ,
2021-08-18 06:17:18 +05:30
Closed : timePtr ( time . Date ( 2019 , 11 , 12 , 21 , 39 , 27 , 0 , time . UTC ) ) ,
2019-05-07 06:42:51 +05:30
Merged : true ,
2021-08-18 06:17:18 +05:30
MergedTime : timePtr ( time . Date ( 2019 , 11 , 12 , 21 , 39 , 27 , 0 , time . UTC ) ) ,
2019-11-13 04:18:21 +05:30
MergeCommitSHA : "f32b0a9dfd09a60f616f29158f772cedd89942d2" ,
Store the foreign ID of issues during migration (#18446)
Storing the foreign identifier of an imported issue in the database is a prerequisite to implement idempotent migrations or mirror for issues. It is a baby step towards mirroring that introduces a new table.
At the moment when an issue is created by the Gitea uploader, it fails if the issue already exists. The Gitea uploader could be modified so that, instead of failing, it looks up the database to find an existing issue. And if it does it would update the issue instead of creating a new one. However this is not currently possible because an information is missing from the database: the foreign identifier that uniquely represents the issue being migrated is not persisted. With this change, the foreign identifier is stored in the database and the Gitea uploader will then be able to run a query to figure out if a given issue being imported already exists.
The implementation of mirroring for issues, pull requests, releases, etc. can be done in three steps:
1. Store an identifier for the element being mirrored (issue, pull request...) in the database (this is the purpose of these changes)
2. Modify the Gitea uploader to be able to update an existing repository with all it contains (issues, pull request...) instead of failing if it exists
3. Optimize the Gitea uploader to speed up the updates, when possible.
The second step creates code that does not yet exist to enable idempotent migrations with the Gitea uploader. When a migration is done for the first time, the behavior is not changed. But when a migration is done for a repository that already exists, this new code is used to update it.
The third step can use the code created in the second step to optimize and speed up migrations. For instance, when a migration is resumed, an issue that has an update time that is not more recent can be skipped and only newly created issues or updated ones will be updated. Another example of optimization could be that a webhook notifies Gitea when an issue is updated. The code triggered by the webhook would download only this issue and call the code created in the second step to update the issue, as if it was in the process of an idempotent migration.
The ForeignReferences table is added to contain local and foreign ID pairs relative to a given repository. It can later be used for pull requests and other artifacts that can be mirrored. Although the foreign id could be added as a single field in issues or pull requests, it would need to be added to all tables that represent something that can be mirrored. Creating a new table makes for a simpler and more generic design. The drawback is that it requires an extra lookup to obtain the information. However, this extra information is only required during migration or mirroring and does not impact the way Gitea currently works.
The foreign identifier of an issue or pull request is similar to the identifier of an external user, which is stored in reactions, issues, etc. as OriginalPosterID and so on. The representation of a user is however different and the ability of users to link their account to an external user at a later time is also a logic that is different from what is involved in mirroring or migrations. For these reasons, despite some commonalities, it is unclear at this time how the two tables (foreign reference and external user) could be merged together.
The ForeignID field is extracted from the issue migration context so that it can be dumped in files with dump-repo and later restored via restore-repo.
The GetAllComments downloader method is introduced to simplify the implementation and not overload the Context for the purpose of pagination. It also clarifies in which context the comments are paginated and in which context they are not.
The Context interface is no longer useful for the purpose of retrieving the LocalID and ForeignID since they are now both available from the PullRequest and Issue struct. The Reviewable and Commentable interfaces replace and serve the same purpose.
The Context data member of PullRequest and Issue becomes a DownloaderContext to clarify that its purpose is not to support in memory operations while the current downloader is acting but is not otherwise persisted. It is, for instance, used by the GitLab downloader to store the IsMergeRequest boolean and sort out issues.
---
[source](https://lab.forgefriends.org/forgefriends/forgefriends/-/merge_requests/36)
Signed-off-by: Loïc Dachary <loic@dachary.org>
Co-authored-by: Loïc Dachary <loic@dachary.org>
2022-03-17 22:38:35 +05:30
ForeignIndex : 3 ,
2019-05-07 06:42:51 +05:30
} ,
{
2019-11-13 04:18:21 +05:30
Number : 4 ,
Title : "Test branch" ,
Content : "do not merge this PR" ,
2019-05-07 06:42:51 +05:30
Milestone : "1.0.0" ,
2019-11-13 04:18:21 +05:30
PosterID : 1669571 ,
PosterName : "mrsdizzie" ,
State : "open" ,
Created : time . Date ( 2019 , 11 , 12 , 21 , 54 , 18 , 0 , time . UTC ) ,
2020-01-14 15:59:22 +05:30
Updated : time . Date ( 2020 , 1 , 4 , 11 , 30 , 1 , 0 , time . UTC ) ,
2019-05-07 06:42:51 +05:30
Labels : [ ] * base . Label {
{
2019-11-13 04:18:21 +05:30
Name : "bug" ,
Color : "d73a4a" ,
Description : "Something isn't working" ,
2019-05-07 06:42:51 +05:30
} ,
} ,
2019-11-13 04:18:21 +05:30
PatchURL : "https://github.com/go-gitea/test_repo/pull/4.patch" ,
2019-05-07 06:42:51 +05:30
Head : base . PullRequestBranch {
2019-11-13 04:18:21 +05:30
Ref : "test-branch" ,
SHA : "2be9101c543658591222acbee3eb799edfc3853d" ,
RepoName : "test_repo" ,
OwnerName : "mrsdizzie" ,
CloneURL : "https://github.com/mrsdizzie/test_repo.git" ,
2019-05-07 06:42:51 +05:30
} ,
Base : base . PullRequestBranch {
2019-11-13 04:18:21 +05:30
Ref : "master" ,
SHA : "f32b0a9dfd09a60f616f29158f772cedd89942d2" ,
2019-05-07 06:42:51 +05:30
OwnerName : "go-gitea" ,
2019-11-13 04:18:21 +05:30
RepoName : "test_repo" ,
2019-05-07 06:42:51 +05:30
} ,
2019-11-13 04:18:21 +05:30
Merged : false ,
MergeCommitSHA : "565d1208f5fffdc1c5ae1a2436491eb9a5e4ebae" ,
2020-01-15 16:44:07 +05:30
Reactions : [ ] * base . Reaction {
{
UserID : 81045 ,
UserName : "lunny" ,
Content : "heart" ,
} ,
{
UserID : 81045 ,
UserName : "lunny" ,
Content : "+1" ,
} ,
} ,
Store the foreign ID of issues during migration (#18446)
Storing the foreign identifier of an imported issue in the database is a prerequisite to implement idempotent migrations or mirror for issues. It is a baby step towards mirroring that introduces a new table.
At the moment when an issue is created by the Gitea uploader, it fails if the issue already exists. The Gitea uploader could be modified so that, instead of failing, it looks up the database to find an existing issue. And if it does it would update the issue instead of creating a new one. However this is not currently possible because an information is missing from the database: the foreign identifier that uniquely represents the issue being migrated is not persisted. With this change, the foreign identifier is stored in the database and the Gitea uploader will then be able to run a query to figure out if a given issue being imported already exists.
The implementation of mirroring for issues, pull requests, releases, etc. can be done in three steps:
1. Store an identifier for the element being mirrored (issue, pull request...) in the database (this is the purpose of these changes)
2. Modify the Gitea uploader to be able to update an existing repository with all it contains (issues, pull request...) instead of failing if it exists
3. Optimize the Gitea uploader to speed up the updates, when possible.
The second step creates code that does not yet exist to enable idempotent migrations with the Gitea uploader. When a migration is done for the first time, the behavior is not changed. But when a migration is done for a repository that already exists, this new code is used to update it.
The third step can use the code created in the second step to optimize and speed up migrations. For instance, when a migration is resumed, an issue that has an update time that is not more recent can be skipped and only newly created issues or updated ones will be updated. Another example of optimization could be that a webhook notifies Gitea when an issue is updated. The code triggered by the webhook would download only this issue and call the code created in the second step to update the issue, as if it was in the process of an idempotent migration.
The ForeignReferences table is added to contain local and foreign ID pairs relative to a given repository. It can later be used for pull requests and other artifacts that can be mirrored. Although the foreign id could be added as a single field in issues or pull requests, it would need to be added to all tables that represent something that can be mirrored. Creating a new table makes for a simpler and more generic design. The drawback is that it requires an extra lookup to obtain the information. However, this extra information is only required during migration or mirroring and does not impact the way Gitea currently works.
The foreign identifier of an issue or pull request is similar to the identifier of an external user, which is stored in reactions, issues, etc. as OriginalPosterID and so on. The representation of a user is however different and the ability of users to link their account to an external user at a later time is also a logic that is different from what is involved in mirroring or migrations. For these reasons, despite some commonalities, it is unclear at this time how the two tables (foreign reference and external user) could be merged together.
The ForeignID field is extracted from the issue migration context so that it can be dumped in files with dump-repo and later restored via restore-repo.
The GetAllComments downloader method is introduced to simplify the implementation and not overload the Context for the purpose of pagination. It also clarifies in which context the comments are paginated and in which context they are not.
The Context interface is no longer useful for the purpose of retrieving the LocalID and ForeignID since they are now both available from the PullRequest and Issue struct. The Reviewable and Commentable interfaces replace and serve the same purpose.
The Context data member of PullRequest and Issue becomes a DownloaderContext to clarify that its purpose is not to support in memory operations while the current downloader is acting but is not otherwise persisted. It is, for instance, used by the GitLab downloader to store the IsMergeRequest boolean and sort out issues.
---
[source](https://lab.forgefriends.org/forgefriends/forgefriends/-/merge_requests/36)
Signed-off-by: Loïc Dachary <loic@dachary.org>
Co-authored-by: Loïc Dachary <loic@dachary.org>
2022-03-17 22:38:35 +05:30
ForeignIndex : 4 ,
2019-05-07 06:42:51 +05:30
} ,
} , prs )
2020-01-23 22:58:15 +05:30
Store the foreign ID of issues during migration (#18446)
Storing the foreign identifier of an imported issue in the database is a prerequisite to implement idempotent migrations or mirror for issues. It is a baby step towards mirroring that introduces a new table.
At the moment when an issue is created by the Gitea uploader, it fails if the issue already exists. The Gitea uploader could be modified so that, instead of failing, it looks up the database to find an existing issue. And if it does it would update the issue instead of creating a new one. However this is not currently possible because an information is missing from the database: the foreign identifier that uniquely represents the issue being migrated is not persisted. With this change, the foreign identifier is stored in the database and the Gitea uploader will then be able to run a query to figure out if a given issue being imported already exists.
The implementation of mirroring for issues, pull requests, releases, etc. can be done in three steps:
1. Store an identifier for the element being mirrored (issue, pull request...) in the database (this is the purpose of these changes)
2. Modify the Gitea uploader to be able to update an existing repository with all it contains (issues, pull request...) instead of failing if it exists
3. Optimize the Gitea uploader to speed up the updates, when possible.
The second step creates code that does not yet exist to enable idempotent migrations with the Gitea uploader. When a migration is done for the first time, the behavior is not changed. But when a migration is done for a repository that already exists, this new code is used to update it.
The third step can use the code created in the second step to optimize and speed up migrations. For instance, when a migration is resumed, an issue that has an update time that is not more recent can be skipped and only newly created issues or updated ones will be updated. Another example of optimization could be that a webhook notifies Gitea when an issue is updated. The code triggered by the webhook would download only this issue and call the code created in the second step to update the issue, as if it was in the process of an idempotent migration.
The ForeignReferences table is added to contain local and foreign ID pairs relative to a given repository. It can later be used for pull requests and other artifacts that can be mirrored. Although the foreign id could be added as a single field in issues or pull requests, it would need to be added to all tables that represent something that can be mirrored. Creating a new table makes for a simpler and more generic design. The drawback is that it requires an extra lookup to obtain the information. However, this extra information is only required during migration or mirroring and does not impact the way Gitea currently works.
The foreign identifier of an issue or pull request is similar to the identifier of an external user, which is stored in reactions, issues, etc. as OriginalPosterID and so on. The representation of a user is however different and the ability of users to link their account to an external user at a later time is also a logic that is different from what is involved in mirroring or migrations. For these reasons, despite some commonalities, it is unclear at this time how the two tables (foreign reference and external user) could be merged together.
The ForeignID field is extracted from the issue migration context so that it can be dumped in files with dump-repo and later restored via restore-repo.
The GetAllComments downloader method is introduced to simplify the implementation and not overload the Context for the purpose of pagination. It also clarifies in which context the comments are paginated and in which context they are not.
The Context interface is no longer useful for the purpose of retrieving the LocalID and ForeignID since they are now both available from the PullRequest and Issue struct. The Reviewable and Commentable interfaces replace and serve the same purpose.
The Context data member of PullRequest and Issue becomes a DownloaderContext to clarify that its purpose is not to support in memory operations while the current downloader is acting but is not otherwise persisted. It is, for instance, used by the GitLab downloader to store the IsMergeRequest boolean and sort out issues.
---
[source](https://lab.forgefriends.org/forgefriends/forgefriends/-/merge_requests/36)
Signed-off-by: Loïc Dachary <loic@dachary.org>
Co-authored-by: Loïc Dachary <loic@dachary.org>
2022-03-17 22:38:35 +05:30
reviews , err := downloader . GetReviews ( & base . PullRequest { Number : 3 , ForeignIndex : 3 } )
2020-01-23 22:58:15 +05:30
assert . NoError ( t , err )
2021-08-18 06:17:18 +05:30
assertReviewsEqual ( t , [ ] * base . Review {
2020-01-23 22:58:15 +05:30
{
ID : 315859956 ,
IssueIndex : 3 ,
ReviewerID : 42128690 ,
ReviewerName : "jolheiser" ,
CommitID : "076160cf0b039f13e5eff19619932d181269414b" ,
CreatedAt : time . Date ( 2019 , 11 , 12 , 21 , 35 , 24 , 0 , time . UTC ) ,
State : base . ReviewStateApproved ,
} ,
{
ID : 315860062 ,
IssueIndex : 3 ,
ReviewerID : 1824502 ,
ReviewerName : "zeripath" ,
CommitID : "076160cf0b039f13e5eff19619932d181269414b" ,
CreatedAt : time . Date ( 2019 , 11 , 12 , 21 , 35 , 36 , 0 , time . UTC ) ,
State : base . ReviewStateApproved ,
} ,
{
ID : 315861440 ,
IssueIndex : 3 ,
ReviewerID : 165205 ,
ReviewerName : "lafriks" ,
CommitID : "076160cf0b039f13e5eff19619932d181269414b" ,
2022-01-05 11:57:53 +05:30
CreatedAt : time . Date ( 2019 , 11 , 12 , 21 , 38 , 0 , 0 , time . UTC ) ,
2020-01-23 22:58:15 +05:30
State : base . ReviewStateApproved ,
} ,
} , reviews )
Store the foreign ID of issues during migration (#18446)
Storing the foreign identifier of an imported issue in the database is a prerequisite to implement idempotent migrations or mirror for issues. It is a baby step towards mirroring that introduces a new table.
At the moment when an issue is created by the Gitea uploader, it fails if the issue already exists. The Gitea uploader could be modified so that, instead of failing, it looks up the database to find an existing issue. And if it does it would update the issue instead of creating a new one. However this is not currently possible because an information is missing from the database: the foreign identifier that uniquely represents the issue being migrated is not persisted. With this change, the foreign identifier is stored in the database and the Gitea uploader will then be able to run a query to figure out if a given issue being imported already exists.
The implementation of mirroring for issues, pull requests, releases, etc. can be done in three steps:
1. Store an identifier for the element being mirrored (issue, pull request...) in the database (this is the purpose of these changes)
2. Modify the Gitea uploader to be able to update an existing repository with all it contains (issues, pull request...) instead of failing if it exists
3. Optimize the Gitea uploader to speed up the updates, when possible.
The second step creates code that does not yet exist to enable idempotent migrations with the Gitea uploader. When a migration is done for the first time, the behavior is not changed. But when a migration is done for a repository that already exists, this new code is used to update it.
The third step can use the code created in the second step to optimize and speed up migrations. For instance, when a migration is resumed, an issue that has an update time that is not more recent can be skipped and only newly created issues or updated ones will be updated. Another example of optimization could be that a webhook notifies Gitea when an issue is updated. The code triggered by the webhook would download only this issue and call the code created in the second step to update the issue, as if it was in the process of an idempotent migration.
The ForeignReferences table is added to contain local and foreign ID pairs relative to a given repository. It can later be used for pull requests and other artifacts that can be mirrored. Although the foreign id could be added as a single field in issues or pull requests, it would need to be added to all tables that represent something that can be mirrored. Creating a new table makes for a simpler and more generic design. The drawback is that it requires an extra lookup to obtain the information. However, this extra information is only required during migration or mirroring and does not impact the way Gitea currently works.
The foreign identifier of an issue or pull request is similar to the identifier of an external user, which is stored in reactions, issues, etc. as OriginalPosterID and so on. The representation of a user is however different and the ability of users to link their account to an external user at a later time is also a logic that is different from what is involved in mirroring or migrations. For these reasons, despite some commonalities, it is unclear at this time how the two tables (foreign reference and external user) could be merged together.
The ForeignID field is extracted from the issue migration context so that it can be dumped in files with dump-repo and later restored via restore-repo.
The GetAllComments downloader method is introduced to simplify the implementation and not overload the Context for the purpose of pagination. It also clarifies in which context the comments are paginated and in which context they are not.
The Context interface is no longer useful for the purpose of retrieving the LocalID and ForeignID since they are now both available from the PullRequest and Issue struct. The Reviewable and Commentable interfaces replace and serve the same purpose.
The Context data member of PullRequest and Issue becomes a DownloaderContext to clarify that its purpose is not to support in memory operations while the current downloader is acting but is not otherwise persisted. It is, for instance, used by the GitLab downloader to store the IsMergeRequest boolean and sort out issues.
---
[source](https://lab.forgefriends.org/forgefriends/forgefriends/-/merge_requests/36)
Signed-off-by: Loïc Dachary <loic@dachary.org>
Co-authored-by: Loïc Dachary <loic@dachary.org>
2022-03-17 22:38:35 +05:30
reviews , err = downloader . GetReviews ( & base . PullRequest { Number : 4 , ForeignIndex : 4 } )
2020-01-23 22:58:15 +05:30
assert . NoError ( t , err )
2021-08-18 06:17:18 +05:30
assertReviewsEqual ( t , [ ] * base . Review {
2020-01-23 22:58:15 +05:30
{
ID : 338338740 ,
IssueIndex : 4 ,
ReviewerID : 81045 ,
ReviewerName : "lunny" ,
CommitID : "2be9101c543658591222acbee3eb799edfc3853d" ,
2022-01-05 11:57:53 +05:30
CreatedAt : time . Date ( 2020 , 1 , 4 , 5 , 33 , 18 , 0 , time . UTC ) ,
2020-01-23 22:58:15 +05:30
State : base . ReviewStateApproved ,
Comments : [ ] * base . ReviewComment {
{
ID : 363017488 ,
Content : "This is a good pull request." ,
TreePath : "README.md" ,
DiffHunk : "@@ -1,2 +1,4 @@\n # test_repo\n Test repository for testing migration from github to gitea\n+" ,
Position : 3 ,
CommitID : "2be9101c543658591222acbee3eb799edfc3853d" ,
PosterID : 81045 ,
2022-01-05 11:57:53 +05:30
CreatedAt : time . Date ( 2020 , 1 , 4 , 5 , 33 , 6 , 0 , time . UTC ) ,
UpdatedAt : time . Date ( 2020 , 1 , 4 , 5 , 33 , 18 , 0 , time . UTC ) ,
2020-01-23 22:58:15 +05:30
} ,
} ,
} ,
{
ID : 338339651 ,
IssueIndex : 4 ,
ReviewerID : 81045 ,
ReviewerName : "lunny" ,
CommitID : "2be9101c543658591222acbee3eb799edfc3853d" ,
2022-01-05 11:57:53 +05:30
CreatedAt : time . Date ( 2020 , 1 , 4 , 6 , 7 , 6 , 0 , time . UTC ) ,
2020-01-23 22:58:15 +05:30
State : base . ReviewStateChangesRequested ,
Content : "Don't add more reviews" ,
} ,
{
ID : 338349019 ,
IssueIndex : 4 ,
ReviewerID : 81045 ,
ReviewerName : "lunny" ,
CommitID : "2be9101c543658591222acbee3eb799edfc3853d" ,
2022-01-05 11:57:53 +05:30
CreatedAt : time . Date ( 2020 , 1 , 4 , 11 , 21 , 41 , 0 , time . UTC ) ,
2020-01-23 22:58:15 +05:30
State : base . ReviewStateCommented ,
Comments : [ ] * base . ReviewComment {
{
ID : 363029944 ,
Content : "test a single comment." ,
TreePath : "LICENSE" ,
DiffHunk : "@@ -19,3 +19,5 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE\n SOFTWARE.\n+" ,
Position : 4 ,
CommitID : "2be9101c543658591222acbee3eb799edfc3853d" ,
PosterID : 81045 ,
2022-01-05 11:57:53 +05:30
CreatedAt : time . Date ( 2020 , 1 , 4 , 11 , 21 , 41 , 0 , time . UTC ) ,
UpdatedAt : time . Date ( 2020 , 1 , 4 , 11 , 21 , 41 , 0 , time . UTC ) ,
2020-01-23 22:58:15 +05:30
} ,
} ,
} ,
} , reviews )
2019-05-07 06:42:51 +05:30
}
