2020-04-05 11:50:50 +05:30
|
|
|
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a MIT-style
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
2018-08-06 10:13:22 +05:30
|
|
|
package models
|
|
|
|
|
|
|
|
import (
|
|
|
|
"testing"
|
|
|
|
|
2022-01-20 04:56:57 +05:30
|
|
|
"code.gitea.io/gitea/models/db"
|
2021-11-12 20:06:47 +05:30
|
|
|
"code.gitea.io/gitea/models/unittest"
|
2021-11-24 15:19:20 +05:30
|
|
|
user_model "code.gitea.io/gitea/models/user"
|
2021-11-17 18:04:35 +05:30
|
|
|
|
2018-08-06 10:13:22 +05:30
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
)
|
|
|
|
|
|
|
|
func TestGetReviewByID(t *testing.T) {
|
2021-11-12 20:06:47 +05:30
|
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
2018-08-06 10:13:22 +05:30
|
|
|
review, err := GetReviewByID(1)
|
|
|
|
assert.NoError(t, err)
|
|
|
|
assert.Equal(t, "Demo Review", review.Content)
|
|
|
|
assert.Equal(t, ReviewTypeApprove, review.Type)
|
|
|
|
|
|
|
|
_, err = GetReviewByID(23892)
|
|
|
|
assert.Error(t, err)
|
|
|
|
assert.True(t, IsErrReviewNotExist(err), "IsErrReviewNotExist")
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestReview_LoadAttributes(t *testing.T) {
|
2021-11-12 20:06:47 +05:30
|
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
2021-11-16 14:23:21 +05:30
|
|
|
review := unittest.AssertExistsAndLoadBean(t, &Review{ID: 1}).(*Review)
|
2022-01-20 04:56:57 +05:30
|
|
|
assert.NoError(t, review.LoadAttributes(db.DefaultContext))
|
2018-08-06 10:13:22 +05:30
|
|
|
assert.NotNil(t, review.Issue)
|
|
|
|
assert.NotNil(t, review.Reviewer)
|
|
|
|
|
2021-11-16 14:23:21 +05:30
|
|
|
invalidReview1 := unittest.AssertExistsAndLoadBean(t, &Review{ID: 2}).(*Review)
|
2022-01-20 04:56:57 +05:30
|
|
|
assert.Error(t, invalidReview1.LoadAttributes(db.DefaultContext))
|
2018-08-06 10:13:22 +05:30
|
|
|
|
2021-11-16 14:23:21 +05:30
|
|
|
invalidReview2 := unittest.AssertExistsAndLoadBean(t, &Review{ID: 3}).(*Review)
|
2022-01-20 04:56:57 +05:30
|
|
|
assert.Error(t, invalidReview2.LoadAttributes(db.DefaultContext))
|
2018-08-06 10:13:22 +05:30
|
|
|
}
|
|
|
|
|
|
|
|
func TestReview_LoadCodeComments(t *testing.T) {
|
2021-11-12 20:06:47 +05:30
|
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
2018-08-06 10:13:22 +05:30
|
|
|
|
2021-11-16 14:23:21 +05:30
|
|
|
review := unittest.AssertExistsAndLoadBean(t, &Review{ID: 4}).(*Review)
|
2022-01-20 04:56:57 +05:30
|
|
|
assert.NoError(t, review.LoadAttributes(db.DefaultContext))
|
|
|
|
assert.NoError(t, review.LoadCodeComments(db.DefaultContext))
|
2018-08-06 10:13:22 +05:30
|
|
|
assert.Len(t, review.CodeComments, 1)
|
|
|
|
assert.Equal(t, int64(4), review.CodeComments["README.md"][int64(4)][0].Line)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestReviewType_Icon(t *testing.T) {
|
2020-04-03 10:42:42 +05:30
|
|
|
assert.Equal(t, "check", ReviewTypeApprove.Icon())
|
2020-07-17 20:45:12 +05:30
|
|
|
assert.Equal(t, "diff", ReviewTypeReject.Icon())
|
2018-08-06 10:13:22 +05:30
|
|
|
assert.Equal(t, "comment", ReviewTypeComment.Icon())
|
|
|
|
assert.Equal(t, "comment", ReviewTypeUnknown.Icon())
|
2020-07-17 20:45:12 +05:30
|
|
|
assert.Equal(t, "dot-fill", ReviewTypeRequest.Icon())
|
2020-04-06 22:03:34 +05:30
|
|
|
assert.Equal(t, "comment", ReviewType(6).Icon())
|
2018-08-06 10:13:22 +05:30
|
|
|
}
|
|
|
|
|
|
|
|
func TestFindReviews(t *testing.T) {
|
2021-11-12 20:06:47 +05:30
|
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
2018-08-06 10:13:22 +05:30
|
|
|
reviews, err := FindReviews(FindReviewOptions{
|
|
|
|
Type: ReviewTypeApprove,
|
|
|
|
IssueID: 2,
|
|
|
|
ReviewerID: 1,
|
|
|
|
})
|
|
|
|
assert.NoError(t, err)
|
|
|
|
assert.Len(t, reviews, 1)
|
|
|
|
assert.Equal(t, "Demo Review", reviews[0].Content)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGetCurrentReview(t *testing.T) {
|
2021-11-12 20:06:47 +05:30
|
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
2021-11-16 14:23:21 +05:30
|
|
|
issue := unittest.AssertExistsAndLoadBean(t, &Issue{ID: 2}).(*Issue)
|
2021-11-24 15:19:20 +05:30
|
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1}).(*user_model.User)
|
2018-08-06 10:13:22 +05:30
|
|
|
|
|
|
|
review, err := GetCurrentReview(user, issue)
|
|
|
|
assert.NoError(t, err)
|
|
|
|
assert.NotNil(t, review)
|
|
|
|
assert.Equal(t, ReviewTypePending, review.Type)
|
|
|
|
assert.Equal(t, "Pending Review", review.Content)
|
|
|
|
|
2021-11-24 15:19:20 +05:30
|
|
|
user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 7}).(*user_model.User)
|
2018-08-06 10:13:22 +05:30
|
|
|
review2, err := GetCurrentReview(user2, issue)
|
|
|
|
assert.Error(t, err)
|
|
|
|
assert.True(t, IsErrReviewNotExist(err))
|
|
|
|
assert.Nil(t, review2)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestCreateReview(t *testing.T) {
|
2021-11-12 20:06:47 +05:30
|
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
2018-08-06 10:13:22 +05:30
|
|
|
|
2021-11-16 14:23:21 +05:30
|
|
|
issue := unittest.AssertExistsAndLoadBean(t, &Issue{ID: 2}).(*Issue)
|
2021-11-24 15:19:20 +05:30
|
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1}).(*user_model.User)
|
2018-08-06 10:13:22 +05:30
|
|
|
|
|
|
|
review, err := CreateReview(CreateReviewOptions{
|
|
|
|
Content: "New Review",
|
|
|
|
Type: ReviewTypePending,
|
|
|
|
Issue: issue,
|
|
|
|
Reviewer: user,
|
|
|
|
})
|
|
|
|
assert.NoError(t, err)
|
|
|
|
assert.Equal(t, "New Review", review.Content)
|
2021-11-16 14:23:21 +05:30
|
|
|
unittest.AssertExistsAndLoadBean(t, &Review{Content: "New Review"})
|
2018-08-06 10:13:22 +05:30
|
|
|
}
|
|
|
|
|
2019-12-04 06:38:56 +05:30
|
|
|
func TestGetReviewersByIssueID(t *testing.T) {
|
2021-11-12 20:06:47 +05:30
|
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
2018-11-22 18:47:36 +05:30
|
|
|
|
2021-11-16 14:23:21 +05:30
|
|
|
issue := unittest.AssertExistsAndLoadBean(t, &Issue{ID: 3}).(*Issue)
|
2021-11-24 15:19:20 +05:30
|
|
|
user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2}).(*user_model.User)
|
|
|
|
user3 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 3}).(*user_model.User)
|
|
|
|
user4 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 4}).(*user_model.User)
|
2018-11-22 18:47:36 +05:30
|
|
|
|
2019-12-04 06:38:56 +05:30
|
|
|
expectedReviews := []*Review{}
|
|
|
|
expectedReviews = append(expectedReviews,
|
|
|
|
&Review{
|
|
|
|
Reviewer: user3,
|
|
|
|
Type: ReviewTypeReject,
|
|
|
|
UpdatedUnix: 946684812,
|
2018-11-22 18:47:36 +05:30
|
|
|
},
|
2019-12-04 06:38:56 +05:30
|
|
|
&Review{
|
|
|
|
Reviewer: user4,
|
|
|
|
Type: ReviewTypeApprove,
|
|
|
|
UpdatedUnix: 946684813,
|
|
|
|
},
|
|
|
|
&Review{
|
|
|
|
Reviewer: user2,
|
|
|
|
Type: ReviewTypeReject,
|
|
|
|
UpdatedUnix: 946684814,
|
2018-11-22 18:47:36 +05:30
|
|
|
})
|
|
|
|
|
2019-12-04 06:38:56 +05:30
|
|
|
allReviews, err := GetReviewersByIssueID(issue.ID)
|
2020-10-13 01:25:13 +05:30
|
|
|
for _, reviewer := range allReviews {
|
|
|
|
assert.NoError(t, reviewer.LoadReviewer())
|
|
|
|
}
|
2018-11-22 18:47:36 +05:30
|
|
|
assert.NoError(t, err)
|
2020-05-02 05:50:51 +05:30
|
|
|
if assert.Len(t, allReviews, 3) {
|
|
|
|
for i, review := range allReviews {
|
|
|
|
assert.Equal(t, expectedReviews[i].Reviewer, review.Reviewer)
|
|
|
|
assert.Equal(t, expectedReviews[i].Type, review.Type)
|
|
|
|
assert.Equal(t, expectedReviews[i].UpdatedUnix, review.UpdatedUnix)
|
|
|
|
}
|
2019-12-04 06:38:56 +05:30
|
|
|
}
|
2018-11-22 18:47:36 +05:30
|
|
|
}
|
2021-02-11 23:02:25 +05:30
|
|
|
|
|
|
|
func TestDismissReview(t *testing.T) {
|
2021-11-12 20:06:47 +05:30
|
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
2021-04-15 15:33:11 +05:30
|
|
|
|
2021-11-16 14:23:21 +05:30
|
|
|
rejectReviewExample := unittest.AssertExistsAndLoadBean(t, &Review{ID: 9}).(*Review)
|
|
|
|
requestReviewExample := unittest.AssertExistsAndLoadBean(t, &Review{ID: 11}).(*Review)
|
|
|
|
approveReviewExample := unittest.AssertExistsAndLoadBean(t, &Review{ID: 8}).(*Review)
|
2021-04-15 15:33:11 +05:30
|
|
|
assert.False(t, rejectReviewExample.Dismissed)
|
|
|
|
assert.False(t, requestReviewExample.Dismissed)
|
|
|
|
assert.False(t, approveReviewExample.Dismissed)
|
|
|
|
|
|
|
|
assert.NoError(t, DismissReview(rejectReviewExample, true))
|
2021-11-16 14:23:21 +05:30
|
|
|
rejectReviewExample = unittest.AssertExistsAndLoadBean(t, &Review{ID: 9}).(*Review)
|
|
|
|
requestReviewExample = unittest.AssertExistsAndLoadBean(t, &Review{ID: 11}).(*Review)
|
2021-04-15 15:33:11 +05:30
|
|
|
assert.True(t, rejectReviewExample.Dismissed)
|
|
|
|
assert.False(t, requestReviewExample.Dismissed)
|
|
|
|
|
|
|
|
assert.NoError(t, DismissReview(requestReviewExample, true))
|
2021-11-16 14:23:21 +05:30
|
|
|
rejectReviewExample = unittest.AssertExistsAndLoadBean(t, &Review{ID: 9}).(*Review)
|
|
|
|
requestReviewExample = unittest.AssertExistsAndLoadBean(t, &Review{ID: 11}).(*Review)
|
2021-04-15 15:33:11 +05:30
|
|
|
assert.True(t, rejectReviewExample.Dismissed)
|
|
|
|
assert.False(t, requestReviewExample.Dismissed)
|
|
|
|
assert.False(t, approveReviewExample.Dismissed)
|
|
|
|
|
|
|
|
assert.NoError(t, DismissReview(requestReviewExample, true))
|
2021-11-16 14:23:21 +05:30
|
|
|
rejectReviewExample = unittest.AssertExistsAndLoadBean(t, &Review{ID: 9}).(*Review)
|
|
|
|
requestReviewExample = unittest.AssertExistsAndLoadBean(t, &Review{ID: 11}).(*Review)
|
2021-04-15 15:33:11 +05:30
|
|
|
assert.True(t, rejectReviewExample.Dismissed)
|
|
|
|
assert.False(t, requestReviewExample.Dismissed)
|
|
|
|
assert.False(t, approveReviewExample.Dismissed)
|
|
|
|
|
|
|
|
assert.NoError(t, DismissReview(requestReviewExample, false))
|
2021-11-16 14:23:21 +05:30
|
|
|
rejectReviewExample = unittest.AssertExistsAndLoadBean(t, &Review{ID: 9}).(*Review)
|
|
|
|
requestReviewExample = unittest.AssertExistsAndLoadBean(t, &Review{ID: 11}).(*Review)
|
2021-04-15 15:33:11 +05:30
|
|
|
assert.True(t, rejectReviewExample.Dismissed)
|
|
|
|
assert.False(t, requestReviewExample.Dismissed)
|
|
|
|
assert.False(t, approveReviewExample.Dismissed)
|
|
|
|
|
|
|
|
assert.NoError(t, DismissReview(requestReviewExample, false))
|
2021-11-16 14:23:21 +05:30
|
|
|
rejectReviewExample = unittest.AssertExistsAndLoadBean(t, &Review{ID: 9}).(*Review)
|
|
|
|
requestReviewExample = unittest.AssertExistsAndLoadBean(t, &Review{ID: 11}).(*Review)
|
2021-04-15 15:33:11 +05:30
|
|
|
assert.True(t, rejectReviewExample.Dismissed)
|
|
|
|
assert.False(t, requestReviewExample.Dismissed)
|
|
|
|
assert.False(t, approveReviewExample.Dismissed)
|
|
|
|
|
|
|
|
assert.NoError(t, DismissReview(rejectReviewExample, false))
|
|
|
|
assert.False(t, rejectReviewExample.Dismissed)
|
|
|
|
assert.False(t, requestReviewExample.Dismissed)
|
|
|
|
assert.False(t, approveReviewExample.Dismissed)
|
|
|
|
|
|
|
|
assert.NoError(t, DismissReview(approveReviewExample, true))
|
|
|
|
assert.False(t, rejectReviewExample.Dismissed)
|
|
|
|
assert.False(t, requestReviewExample.Dismissed)
|
|
|
|
assert.True(t, approveReviewExample.Dismissed)
|
|
|
|
|
2021-02-11 23:02:25 +05:30
|
|
|
}
|