mystiq/sso
Archived
4
0
Fork 2
Code Issues Pull requests Projects Releases Packages Wiki Activity

local_settings.py: clean way to store deployment secrets #3

Merged
alan2000alex merged 2 commits from realaravinth/mystiq-sso:wip-local-settings into master 2022-08-22 19:46:45 +05:30
Conversation 0 Commits 2 Files changed 7 +46 -3
realaravinth commented 2022-08-22 17:37:34 +05:30
Owner
Copy link

Modifying sso/settings.py is not ergonomic, it might change with every iteration. Using sso/local_settings/local_settings.py to override sso/settings.py with deployment-specific, confidential configuration is safer and cleaner too.

  • ./sso/local_settings/local_settings.py: deployment-specific confidential configuration parameters
  • ./sso/local_settings/local_settings.example.py: an example of the above file

ref: mystiq/MVP#33

Modifying `sso/settings.py` is not ergonomic, it might change with every iteration. Using `sso/local_settings/local_settings.py` to override `sso/settings.py` with deployment-specific, confidential configuration is safer and cleaner too. - `./sso/local_settings/local_settings.py`: deployment-specific confidential configuration parameters - `./sso/local_settings/local_settings.example.py`: an example of the above file ref: https://git.batsense.net/mystiq/MVP/issues/33
realaravinth self-assigned this 2022-08-22 17:37:34 +05:30
realaravinth added 2 commits 2022-08-22 17:37:35 +05:30
feat: use local_settings in docker-compose
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
Details
2e9cc6aa7f
realaravinth requested review from alan2000alex 2022-08-22 17:37:42 +05:30
realaravinth requested review from harikrishnajiju 2022-08-22 17:37:42 +05:30
alan2000alex approved these changes 2022-08-22 19:46:27 +05:30
alan2000alex merged commit 8f62c31d49 into master 2022-08-22 19:46:45 +05:30
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
harikrishnajiju
alan2000alex
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
realaravinth
2 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: mystiq/sso#3
No description provided.
Delete branch "realaravinth/mystiq-sso:wip-local-settings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?