mystiq/rageshake
Archived
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

iterate PR

Browse source
This commit is contained in:
Michael Telatynski 2020-04-04 11:58:38 +01:00
parent 9f6217d159
commit 6ffa32a236
2 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
submit.go
View file

@ -120,11 +120,13 @@ type submitResponse struct {
ReportURL string `json:"report_url,omitempty"` ReportURL string `json:"report_url,omitempty"`
} }
// regex to catch and substitute ambiguous issue references with explicit ones to the actual repo they are in // regex to match and substitute ambiguous issue references in the rageshake body text
var ambiguousIssueRegex = regexp.MustCompile(`(^|[([{\s])(#\d+)([^\w]|$)`) // matches a hash followed by digits optionally surrounded by whitespace or some punctuation
// also matches if the input starts with digits where the hash becomes optional
var ambiguousIssueRegex = regexp.MustCompile(`(^|[([{\s])(?:^|#)(\d+)([^\w]|$)`)
func replaceAmbiguousIssueReferences(ownerRepo, text string) string { func replaceAmbiguousIssueReferences(ownerRepo, text string) string {
t := ambiguousIssueRegex.ReplaceAllString(text, fmt.Sprintf("${1}%s$2$3", ownerRepo)) t := ambiguousIssueRegex.ReplaceAllString(text, fmt.Sprintf("${1}%s#$2$3", ownerRepo))
return t return t
} }

2
submit_test.go
View file

@ -492,6 +492,8 @@ func TestAutocompleteIssueReferences(t *testing.T) {
"test (#123) bar": "test (owner/repo#123) bar", // brackets "test (#123) bar": "test (owner/repo#123) bar", // brackets
"Start #123. Now": "Start owner/repo#123. Now", // followed by punctuation "Start #123. Now": "Start owner/repo#123. Now", // followed by punctuation
"#123foo": "#123foo", // ignore "#123foo": "#123foo", // ignore
"foo/#123": "foo/#123", // ignore
"123": "owner/repo#123", // special case for entire body being a number
} }
for text, expect := range tests { for text, expect := range tests {