RMidhunSuresh
|
88a1e34987
|
Unsubscribe on dispose
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-14 21:04:44 +05:30 |
|
RMidhunSuresh
|
7b811aa927
|
Remove space after brace in two places
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-14 20:33:32 +05:30 |
|
RMidhunSuresh
|
e10b455b27
|
Rename method
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-14 20:32:05 +05:30 |
|
RMidhunSuresh
|
e2443a8b09
|
Undo spillover from earlier formatting havoc
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
b2f2d51594
|
Make formatting consistent with the codebase
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
0c5d118bfd
|
Add rule to warn on wrong formatting
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
dd9a19b7f0
|
Make formatting consistent
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
4005d70bb9
|
Increase height to make element more centered
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
fa67c5e248
|
Refactor function
- Move related parameters closer together.
- Remove unused parameter.
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
95512b5144
|
Remove margin from top
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
6086d157e2
|
Make value multiple of 4
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
2c0176f3f2
|
Remove unwanted width
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
f3f1436bb0
|
Rename room info to room details everywhere
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
f917730a21
|
Stick to naming convention for css/html classes
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
efd37d811f
|
Update on changes to vm
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
008f3601ca
|
Remove link support from Menu
- Not needed anymore since every link item has been rewritten as a
button.
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
332fbdda84
|
Move variable to scope of conditional
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
7fbcf89539
|
Remove unncessary empty line
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
eb870cfc23
|
Use url instead of link
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
fcc2afba08
|
Do not compute link in getter
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
04065847dc
|
Remove unused getter
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
c6f3b1fbbe
|
Do not use private props from room summary
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
4700009c68
|
Add new test for parseUrlPath
Make sure that the details panel stays open during room change.
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
4c962943b2
|
Modify setters in MenuOption to support chaining
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
0d63ce9a3a
|
Change SideBarActive --> right-shown
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
5b74038912
|
Check value of details everywhere
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
b2448e1207
|
Calculate path when button is clicked
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
37e052c061
|
details do not need to be child of rooms
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
a4bcb21a85
|
Move details handling to separate function
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
7f922afe79
|
Reduce duplication in code
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
04933acbfb
|
Add missing checks
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
a3587a80c6
|
Use internationalization for user facing strings
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
986f04aac0
|
Move Room details menu entry to top
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
9074caf443
|
Change Room Details --> Room details
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
65bd74442f
|
Make menu-items uniform
- Same font ,font-size and height.
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
98ef6f4321
|
Use optionWithButton
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
a3271fb916
|
Fix Menu: Use t instead of tag to get events
- Also move constructor up
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
8d254c91e3
|
Undo formatting/stylistic changes
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
3273682155
|
Do not show room id instead of canonical alias
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
d3d65d89ba
|
Put sidebar rows into container
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
f1fe17fe65
|
Make font-size equal to that of room-header
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
040c744b6a
|
Style links and buttons similarly in menu
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
00dbd3db06
|
Add menu entry to launch RoomInfoView
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
1e96b58f85
|
Add link support to menu
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
426d0779ee
|
Keep RoomInfoView open across room/grid changes
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
02d79b52a4
|
Prefer canonical alias over room_id if available
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
2dcec6343d
|
Info icon should open/close view alternatively
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
d782c9e0bb
|
Justify content to flex-end instead
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
eab6ca3baf
|
Make side-bar responsive
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|
RMidhunSuresh
|
9ac415fa4f
|
Show panel when first visit contains /details
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
|
2021-06-09 16:51:18 +05:30 |
|