mystiq/hydrogen-web
Archived
4
1
Fork 1
Code Issues Pull requests Packages Projects Releases Wiki Activity
2155 commits 367 branches 115 tags 16 MiB
Commit graph

401 commits

Author SHA1 Message Date
Bruno Windels 762ed96a3b Not needed as both evententry and pendingevententry return timestamp 2021-05-31 11:58:01 +02:00
Bruno Windels 0596ca06b1 emit remove before linking up sibling tiles 
otherwise emitting the update from updatePreviousSibling has
the wrong idx
 2021-05-31 11:56:41 +02:00
Bruno Windels c6e2607f1f guard against updates emitted while populating during first subscription 
This came up now because Timeline uses a MappedList to map PendingEvents
to PendingEventEntries. In the map function, we setup links between
entries to support local echo for relations. When opening a timeline
that has unsent relations, the initial populating of the MappedList
will try to emit an update for the target entry in remoteEntries.
This all happens while the ListView of the timeline is calling subscribe
and all collections in the chain are populating themselves based on
their sources.

This usually entails calling subscribe on the source,
and now you are subscribed, iterate over the source (as you're not
allowed to query an unsubscribed observable collection, as it might not
be populated yet, and even if it did, it wouldn't be guaranteed to be
up to date as events aren't flowing yet).

So in this concrete example, TilesCollection hadn't populated its tiles
yet and when the update to the target of the unsent relation reached
TilesCollection, the tiles array was still null and it crashed.

I thought what would be the best way to fix this and have a solid model
for observable collections to ensure they are always compatible with
each other. I considered splitting up the subscription process in two
steps where you'd first populate the source and then explicitly start
events flowing.

I didn't go with this way because it's really only updates that
make sense to be emitted during setup.
A missed update wouldn't usually bring the collections out of sync
like a missed add or remove would. It would just mean the UI isn't
updated (or any subsequent filtered collections are not updated),
but this should be fine to ignore during setup, as you can rely
on the subscribing collections down the chain picking up the update
while populating. If we ever want to support add or remove events
during setup, we would have to explicitly support them, but for now
they are correct to throw.

So for now, just ignore update events that happen during setup
where needed.
 2021-05-27 10:02:05 +02:00
Bruno Windels a8e43d4850 remove leftover logging 2021-05-27 09:18:22 +02:00
Bruno Windels 56495c9d13 fix gap failing to fill 2nd time + unit regression test 2021-05-27 09:10:10 +02:00
Bruno Windels ca4d09e923 add logging and return promise from Tile.redact 2021-05-26 13:08:54 +02:00
Bruno Windels ce7147e463 put redactions in their own view, and allow aborting while still queued 2021-05-26 13:07:56 +02:00
Bruno Windels cb622be653 rerender tile when becoming or stopped being redacted 2021-05-25 12:58:20 +02:00
Bruno Windels 8a8c5569dc provide redact method on tile and room 
also add some logging
 2021-05-20 14:53:17 +02:00
Bruno Windels b655c34bbb also show reason for redaction 2021-05-20 13:20:12 +02:00
Bruno Windels 780ad44032 render redacted messages 2021-05-20 13:15:35 +02:00
Bruno Windels 1f17edc248 fix undefined variable, this probably breaks restoring the last url 2021-05-20 11:11:07 +02:00
Bruno Windels df8686099f
Merge pull request #356 from MidhunSureshR/linkify-doc 
Add jsdoc comments for clickable link code + Minor Changes
 2021-05-18 13:30:23 +00:00
Bruno Windels c3ef801566 offer back button when session loading fails 2021-05-18 15:27:31 +02:00
Bruno Windels d567664d8b ensure there is a session id in last-session action 2021-05-18 14:47:45 +02:00
Bruno Windels 2c7ea44afd don't expose last url to root VM so it isn't confused by empty path 
instead, check the length of the path in a dedicated method in
the router
 2021-05-18 14:27:09 +02:00
Bruno Windels dd880529ac make redirects in initial url be reflected in url bar 2021-05-18 13:52:31 +02:00
Bruno Windels 1bec1033d1 translate last-session to a real session id 2021-05-18 13:52:13 +02:00
Bruno Windels 754e7e7bb2 clarify with comments 2021-05-18 11:54:18 +02:00
Bruno Windels f92b1df4fc update copyright comments 2021-05-18 11:54:10 +02:00
Bruno Windels 54798d3079 unreachable now 2021-05-18 11:50:02 +02:00
Bruno Windels 2cf100efaa refine unknown room view 2021-05-18 11:46:55 +02:00
Bruno Windels c04a8140a3 offer to rejoin archived room from menu 2021-05-18 11:07:46 +02:00
Bruno Windels 03be63572d ask to join when room id is unknown 2021-05-18 11:07:19 +02:00
Bruno Windels 3acb3bb48c fix memory leak when switching room ids 2021-05-18 11:06:48 +02:00
RMidhunSuresh 72f58b6001 Change lines[i] to line 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
 2021-05-18 14:26:56 +05:30
RMidhunSuresh 11d551f8a3 Add js-doc for parsePlainBody 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
 2021-05-17 20:39:23 +05:30
RMidhunSuresh d671bcec31 Add js-docs for linkify function 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
 2021-05-17 20:32:35 +05:30
Bruno Windels 645470cd03 no need for private prop here 2021-05-17 12:45:55 +02:00
Bruno Windels ce976226f9 rename MessageTile to BaseMessageTile 
since MessageTile doesn't have a shape property anymore
 2021-05-17 12:15:13 +02:00
Bruno Windels 67714040e7 rename BaseTextMessageTile to BaseTextTile 2021-05-17 12:14:15 +02:00
Bruno Windels 054c51b82f add caching MessageBody in BaseTextMessageTile,use in EncryptedEventTile 
missing body in EncryptedEventTile was what caused the bug
 2021-05-17 11:27:30 +02:00
Bruno Windels 01b8b397b6 expose sourceString on result of parsing message body 
and also do some cleanup
 2021-05-17 11:26:30 +02:00
Bruno Windels 62bb891e79 don't accept closing parenthesis as last character of url 2021-05-12 22:49:34 +02:00
Bruno Windels 56699baaf1 dont need this anymore 2021-05-12 18:31:13 +02:00
Bruno Windels 86d60496c0 Don't move read rooms to lower sorting position 2021-05-12 18:28:39 +02:00
Bruno Windels 402a5e5d54 fix room list sorting not keeping sorting position after clearing unread 2021-05-12 18:26:55 +02:00
Bruno Windels 93c08c16c1
Merge pull request #345 from MidhunSureshR/linkify 
Render URLs as clickable links in timeline
 2021-05-12 15:40:46 +00:00
Bruno Windels b30b62416c add option to forget archived room 2021-05-12 15:38:54 +02:00
Bruno Windels f331d84292 add options menu in room header with leave room option 2021-05-12 13:59:08 +02:00
RMidhunSuresh 851e8d34a4 Incorporate better regex from review 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
 2021-05-12 16:15:30 +05:30
RMidhunSuresh 00bcdbab37 Fix broken test 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
 2021-05-12 16:15:07 +05:30
RMidhunSuresh bb74656348 Grammar fix 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
 2021-05-12 15:59:44 +05:30
RMidhunSuresh 2e657fbbbd Add failing test for link ending with < 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
 2021-05-12 15:56:33 +05:30
RMidhunSuresh 55b7c55efe Pull callback args into variables 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
 2021-05-12 15:52:05 +05:30
RMidhunSuresh 9d898bdf47 Change word to improve meaning 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
 2021-05-11 22:32:05 +05:30
RMidhunSuresh b521797f4d Explain the reason for double escapes 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
 2021-05-11 22:28:14 +05:30
RMidhunSuresh ef15968a3d Add some helpful pointers 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
 2021-05-11 22:26:45 +05:30
RMidhunSuresh c6d7cef491 Refactor regex to improve readability 
- Split regex into components
- Add informative comments

Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
 2021-05-11 22:21:37 +05:30
RMidhunSuresh 31740f4ec6 Put regex into separate file 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
 2021-05-11 22:18:52 +05:30