From f2f9162b854e23697fbe0eb13241f2a010bd827d Mon Sep 17 00:00:00 2001 From: Bruno Windels Date: Thu, 18 Feb 2021 19:46:40 +0100 Subject: [PATCH] log pagehide event --- src/logging/BaseLogger.js | 8 +++++++- src/logging/IDBLogger.js | 1 + src/logging/LogItem.js | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/logging/BaseLogger.js b/src/logging/BaseLogger.js index ea935a8f..dff929a6 100644 --- a/src/logging/BaseLogger.js +++ b/src/logging/BaseLogger.js @@ -23,6 +23,12 @@ export class BaseLogger { this._platform = platform; } + log(labelOrValues, logLevel = LogLevel.Info) { + const item = new LogItem(labelOrValues, logLevel, null, this._platform.clock); + item._end = item._start; + this._persistItem(item.serialize(null)); + } + run(labelOrValues, callback, logLevel = LogLevel.Info, filterCreator = null) { const item = new LogItem(labelOrValues, logLevel, null, this._platform.clock); this._openItems.add(item); @@ -31,7 +37,7 @@ export class BaseLogger { let filter = new LogFilter(); if (filterCreator) { try { - filter = filterCreator(filter, this); + filter = filterCreator(filter, item); } catch (err) { console.error("Error while creating log filter", err); } diff --git a/src/logging/IDBLogger.js b/src/logging/IDBLogger.js index 751af37e..0ff21034 100644 --- a/src/logging/IDBLogger.js +++ b/src/logging/IDBLogger.js @@ -82,6 +82,7 @@ export class IDBLogger extends BaseLogger { _finishAllAndFlush() { this._finishOpenItems(); + this.log({l: "pagehide, closing logs", t: "navigation"}); this._persistQueuedItems(this._queuedItems); } diff --git a/src/logging/LogItem.js b/src/logging/LogItem.js index 4fbddfcc..75f91fe7 100644 --- a/src/logging/LogItem.js +++ b/src/logging/LogItem.js @@ -86,7 +86,7 @@ export class LogItem { return array; }, null); } - if (!filter.filter(this, children)) { + if (filter && !filter.filter(this, children)) { return null; } // in (v)alues, (l)abel and (t)ype are also reserved.