From eb60f6717a11ccd1426717f55f14a494982873f4 Mon Sep 17 00:00:00 2001
From: Bruno Windels <bruno@windels.cloud>
Date: Thu, 7 Oct 2021 15:57:02 +0200
Subject: [PATCH] add comment for improvements

---
 scripts/build-plugins/service-worker.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/build-plugins/service-worker.js b/scripts/build-plugins/service-worker.js
index d80f0bbf..901f0395 100644
--- a/scripts/build-plugins/service-worker.js
+++ b/scripts/build-plugins/service-worker.js
@@ -33,6 +33,9 @@ module.exports = function injectServiceWorker(swFile) {
             const globalHash = getBuildHash(cachedFileNames, uncachedFileContentMap);
             swSource = await buildServiceWorker(swSource, version, globalHash, assets);
             const outputName = path.basename(absoluteSwFile);
+            // TODO: do normal build transformations for service worker too,
+            // I think if we emit it as a chunk rather than an asset it would
+            // but we can't emit chunks anymore in generateBundle I think ...
             this.emitFile({
                 type: "asset",
                 fileName: outputName,