From 69d8e6031ef25975b95864446c17f8e095fd586a Mon Sep 17 00:00:00 2001 From: RMidhunSuresh Date: Tue, 14 Jun 2022 19:26:59 +0530 Subject: [PATCH 1/2] This isn't used anywhere --- src/domain/session/settings/SettingsViewModel.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/domain/session/settings/SettingsViewModel.js b/src/domain/session/settings/SettingsViewModel.js index eed18953..d844e21b 100644 --- a/src/domain/session/settings/SettingsViewModel.js +++ b/src/domain/session/settings/SettingsViewModel.js @@ -187,9 +187,5 @@ export class SettingsViewModel extends ViewModel { // emit so that radio-buttons become displayed/hidden this.emitChange("themeOption"); } - - get preferredColorScheme() { - return this.platform.themeLoader.preferredColorScheme; - } } From d00ea39dc4f8306c5b656574ce3e958f0d342e99 Mon Sep 17 00:00:00 2001 From: RMidhunSuresh Date: Tue, 14 Jun 2022 19:27:18 +0530 Subject: [PATCH 2/2] No need to throw here --- src/platform/web/ThemeLoader.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/platform/web/ThemeLoader.ts b/src/platform/web/ThemeLoader.ts index 6a73c565..8c9364bc 100644 --- a/src/platform/web/ThemeLoader.ts +++ b/src/platform/web/ThemeLoader.ts @@ -196,13 +196,12 @@ export class ThemeLoader { } } - get preferredColorScheme(): ColorSchemePreference { + get preferredColorScheme(): ColorSchemePreference | undefined { if (window.matchMedia("(prefers-color-scheme: dark)").matches) { return ColorSchemePreference.Dark; } else if (window.matchMedia("(prefers-color-scheme: light)").matches) { return ColorSchemePreference.Light; } - throw new Error("Cannot find preferred colorscheme!"); } }