mystiq/hydrogen-web
Archived
4
1
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity

ensure any breakage does not disrupt logging

Browse source
This commit is contained in:
Bruno Windels 2021-02-16 18:36:41 +01:00
parent 2dd8803efc
commit c3637def2e
3 changed files with 14 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/logging/BaseLogger.js
View file

@ -30,7 +30,11 @@ export class BaseLogger {
const finishItem = () => { const finishItem = () => {
let filter = new LogFilter(); let filter = new LogFilter();
if (filterCreator) { if (filterCreator) {
try {
filter = filterCreator(filter, this); filter = filterCreator(filter, this);
} catch (err) {
console.error("Error while creating log filter", err);
}
} else { } else {
// if not filter is specified, filter out anything lower than the initial log level // if not filter is specified, filter out anything lower than the initial log level
filter = filter.minLevel(logLevel); filter = filter.minLevel(logLevel);
@ -41,7 +45,7 @@ export class BaseLogger {
this._persistItem(serialized); this._persistItem(serialized);
} }
} catch (err) { } catch (err) {
console.warn("Could not serialize log item", err); console.error("Could not serialize log item", err);
} }
this._openItems.delete(item); this._openItems.delete(item);
}; };
@ -75,7 +79,7 @@ export class BaseLogger {
this._persistItem(serialized); this._persistItem(serialized);
} }
} catch (err) { } catch (err) {
console.warn("Could not serialize log item", err); console.error("Could not serialize log item", err);
} }
} }
this._openItems.clear(); this._openItems.clear();

4
src/logging/IDBLogger.js
View file

@ -72,7 +72,7 @@ export class IDBLogger extends BaseLogger {
await txnAsPromise(txn); await txnAsPromise(txn);
this._queuedItems.splice(0, amount); this._queuedItems.splice(0, amount);
} catch (err) { } catch (err) {
console.warn("Could not flush logs", err); console.error("Could not flush logs", err);
} finally { } finally {
try { try {
db.close(); db.close();
@ -113,7 +113,7 @@ export class IDBLogger extends BaseLogger {
try { try {
window.localStorage.setItem(`${this._name}_queuedItems`, JSON.stringify(items)); window.localStorage.setItem(`${this._name}_queuedItems`, JSON.stringify(items));
} catch (e) { } catch (e) {
console.warn("Could not persist queued log items in localStorage, they will likely be lost", e); console.error("Could not persist queued log items in localStorage, they will likely be lost", e);
} }
} }

4
src/logging/LogItem.js
View file

@ -66,7 +66,11 @@ export class LogItem {
serialize(filter, depth) { serialize(filter, depth) {
if (this._filterCreator) { if (this._filterCreator) {
try {
filter = this._filterCreator(new LogFilter(filter), this); filter = this._filterCreator(new LogFilter(filter), this);
} catch (err) {
console.error("Error creating log item", err);
}
} }
let children; let children;
if (this._children !== null) { if (this._children !== null) {