Merge pull request #267 from vector-im/bwindels/fix-223
consider all server errors as connection errors
This commit is contained in:
commit
b4f4594ead
1 changed files with 6 additions and 1 deletions
|
@ -29,12 +29,17 @@ class RequestWrapper {
|
||||||
log?.finish();
|
log?.finish();
|
||||||
return response.body;
|
return response.body;
|
||||||
} else {
|
} else {
|
||||||
if (response.status >= 400 && !response.body?.errcode) {
|
if (response.status >= 500) {
|
||||||
|
const err = new ConnectionError(`Internal Server Error`);
|
||||||
|
log?.catch(err);
|
||||||
|
throw err;
|
||||||
|
} else if (response.status >= 400 && !response.body?.errcode) {
|
||||||
const err = new ConnectionError(`HTTP error status ${response.status} without errcode in body, assume this is a load balancer complaining the server is offline.`);
|
const err = new ConnectionError(`HTTP error status ${response.status} without errcode in body, assume this is a load balancer complaining the server is offline.`);
|
||||||
log?.catch(err);
|
log?.catch(err);
|
||||||
throw err;
|
throw err;
|
||||||
} else {
|
} else {
|
||||||
const err = new HomeServerError(method, url, response.body, response.status);
|
const err = new HomeServerError(method, url, response.body, response.status);
|
||||||
|
log?.set("errcode", err.errcode);
|
||||||
log?.catch(err);
|
log?.catch(err);
|
||||||
throw err;
|
throw err;
|
||||||
}
|
}
|
||||||
|
|
Reference in a new issue