mystiq/hydrogen-web
Archived
4
1
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity

no need to store visible state on gap tile & don't fill if edge reached

Browse source
This commit is contained in:
Bruno Windels 2021-09-08 16:39:46 +02:00
parent ab67ac00b1
commit 98678b991b
1 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/domain/session/room/timeline/tiles/GapTile.js
View file

@ -22,12 +22,10 @@ export class GapTile extends SimpleTile {
super(options); super(options);
this._loading = false; this._loading = false;
this._error = null; this._error = null;
this._visible = false;
} }
async fill() { async fill() {
// prevent doing this twice if (!this._loading && !this._entry.edgeReached) {
if (!this._loading) {
this._loading = true; this._loading = true;
this.emitChange("isLoading"); this.emitChange("isLoading");
try { try {
@ -44,13 +42,10 @@ export class GapTile extends SimpleTile {
this.emitChange("isLoading"); this.emitChange("isLoading");
} }
} }
// edgeReached will have been updated by fillGap
return this._entry.edgeReached;
} }
setVisible(isVisible) { setVisible(isVisible) {
this._visible = isVisible; if (isVisible) {
if (this._visible && !this.isLoading) {
this.fill(); this.fill();
} }
} }