fix icons in manifest not being found

scripts/build-plugins/manifest.js

@@ -32,7 +32,10 @@ module.exports = function injectWebManifest(manifestFile) {
                     name: path.basename(iconFileName),
                     source: imgData
                 });
-                icon.src = this.getFileName(ref);
+                // we take the basename as getFileName gives the filename
+                // relative to the output dir, but the manifest is an asset
+                // just like they icon, so we assume they end up in the same dir
+                icon.src = path.basename(this.getFileName(ref));
             }
             const outputName = path.basename(absoluteManifestFile);
             const manifestRef = this.emitFile({

vite.config.js

@@ -47,6 +47,8 @@ export default {
         // }, "hydrogen-legacy", [
         //     './legacy-polyfill',
         // ]),
+        // important this comes before service worker
+        // otherwise the manifest and the icons it refers to won't be cached
         injectWebManifest("assets/manifest.json"),
         injectServiceWorker("sw.js"),
     ],