mystiq/hydrogen-web
Archived
4
1
Fork 1
Code Issues Pull requests Packages Projects Releases Wiki Activity

fix icons in manifest not being found

Browse source
This commit is contained in:
Bruno Windels 2021-12-06 15:25:44 +01:00
parent 155cd4c9bd
commit 91e69a2bd0
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
scripts/build-plugins/manifest.js
View file

@ -32,7 +32,10 @@ module.exports = function injectWebManifest(manifestFile) {
name: path.basename(iconFileName), name: path.basename(iconFileName),
source: imgData source: imgData
}); });
icon.src = this.getFileName(ref); // we take the basename as getFileName gives the filename
// relative to the output dir, but the manifest is an asset
// just like they icon, so we assume they end up in the same dir
icon.src = path.basename(this.getFileName(ref));
} }
const outputName = path.basename(absoluteManifestFile); const outputName = path.basename(absoluteManifestFile);
const manifestRef = this.emitFile({ const manifestRef = this.emitFile({

2
vite.config.js
View file

@ -47,6 +47,8 @@ export default {
// }, "hydrogen-legacy", [ // }, "hydrogen-legacy", [
// './legacy-polyfill', // './legacy-polyfill',
// ]), // ]),
// important this comes before service worker
// otherwise the manifest and the icons it refers to won't be cached
injectWebManifest("assets/manifest.json"), injectWebManifest("assets/manifest.json"),
injectServiceWorker("sw.js"), injectServiceWorker("sw.js"),
], ],