From 8cd430ac0703a717e5bbe002a1c9d6ba73287ed8 Mon Sep 17 00:00:00 2001 From: RMidhunSuresh Date: Fri, 14 Jan 2022 17:48:25 +0530 Subject: [PATCH] Improve test logic --- src/matrix/room/timeline/Timeline.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/matrix/room/timeline/Timeline.js b/src/matrix/room/timeline/Timeline.js index a26237e7..9638f60c 100644 --- a/src/matrix/room/timeline/Timeline.js +++ b/src/matrix/room/timeline/Timeline.js @@ -859,11 +859,11 @@ export function tests() { const entryB = new EventEntry({ event: withContent(content, createEvent("m.room.message", "event_id_2", bob)), eventIndex: 2 }); const entryC = new EventEntry({ event: withContent(content, createEvent("m.room.message", "event_id_3", bob)), eventIndex: 3 }); await timeline.load(new User(alice), "join", new NullLogItem()); - const bin = [entryB, entryC]; + const bin = []; timeline.entries.subscribe({ onUpdate: (index) => { - const i = bin.findIndex(e => e.id === index); - bin.splice(i, 1); + const e = timeline.remoteEntries[index]; + bin.push(e.id); }, onAdd: () => null, }); @@ -871,7 +871,8 @@ export function tests() { await poll(() => timeline._remoteEntries.array.length === 2 && timeline._contextEntriesNotInTimeline.get("event_id_1")); const redactingEntry = new EventEntry({ event: withRedacts("event_id_1", "foo", createEvent("m.room.redaction", "event_id_3", alice)) }); timeline.addEntries([redactingEntry]); - assert.strictEqual(bin.length, 0); + assert.strictEqual(bin.includes("event_id_2"), true); + assert.strictEqual(bin.includes("event_id_3"), true); }, "context entries fetched from storage/hs are moved to remoteEntries": async assert => {