From 825c9847fe756351f4662146968fcb78cb32d6c3 Mon Sep 17 00:00:00 2001
From: RMidhunSuresh <hi@midhun.dev>
Date: Wed, 13 Apr 2022 12:56:14 +0530
Subject: [PATCH] Don't hardcode theme/variant names

---
 .../rollup-plugin-build-themes.js             | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/scripts/build-plugins/rollup-plugin-build-themes.js b/scripts/build-plugins/rollup-plugin-build-themes.js
index 34dae562..ef1eb78b 100644
--- a/scripts/build-plugins/rollup-plugin-build-themes.js
+++ b/scripts/build-plugins/rollup-plugin-build-themes.js
@@ -131,24 +131,27 @@ module.exports = function buildThemes(options) {
                 if (id.startsWith(resolvedVirtualModuleId)) {
                     let [theme, variant, file] = id.substr(resolvedVirtualModuleId.length).split("/");
                     if (theme === "default") {
-                        theme = "element";
+                        theme = options.themeConfig.default;
                     }
+                    const location = options.themeConfig.themes[theme];
+                    const manifest = require(`${location}/manifest.json`);
+                    const variants = manifest.values.variants;
                     if (!variant || variant === "default") {
-                        variant = "light";
+                        // choose the first default variant for now
+                        // this will need to support light/dark variants as well
+                        variant = Object.keys(variants).find(variantName => variants[variantName].default);
                     }
                     if (!file) {
                         file = "index.js";
                     }
-                    const location = options.themeConfig.themes[theme];
-                    const manifest = require(`${location}/manifest.json`);
                     switch (file) {
                         case "index.js": {
-                            const isDark = manifest.values.variants[variant].dark;
+                            const isDark = variants[variant].dark;
                             return `import "${path.resolve(`${location}/theme.css`)}${isDark? "?dark=true": ""}";` +
                                 `import "@theme/${theme}/${variant}/variables.css"`;
                         }
                         case "variables.css": { 
-                            const variables = manifest.values.variants[variant].variables;
+                            const variables = variants[variant].variables;
                             const css =  getRootSectionWithVariables(variables);
                             return css;
                         }
@@ -161,7 +164,7 @@ module.exports = function buildThemes(options) {
                     const [, location, variant] = result;
                     const cssSource = await readCSSSource(location);
                     const config = variants[variant];
-                    return await appendVariablesToCSS(config.variables, cssSource);
+                    return appendVariablesToCSS(config.variables, cssSource);
                 }
                 return null;
             }
@@ -213,7 +216,7 @@ module.exports = function buildThemes(options) {
                     }
                 },
             ];
-        },
+},
 
         generateBundle(_, bundle) {
             const { assetMap, chunkMap, runtimeThemeChunk } = parseBundle(bundle);