Improve performance of room list re-rendering
Only re-render if the room ID has changed, this stops flickering when new messages come in.
This commit is contained in:
parent
7f653ab531
commit
7d35e861e3
1 changed files with 12 additions and 6 deletions
|
@ -70,13 +70,19 @@ export class LeftPanelView extends TemplateView {
|
|||
vm.loadRoomRange(range);
|
||||
},
|
||||
shouldRecreateItem: (value, oldValue) => {
|
||||
const oldIsPlaceholder = oldValue instanceof PlaceholderRoomTileViewModel;
|
||||
const newIsPlaceholder = value instanceof PlaceholderRoomTileViewModel;
|
||||
if (oldIsPlaceholder != newIsPlaceholder) {
|
||||
return true;
|
||||
// TODO: We used to just recreate the item if the underlying view model was swapped out e.g ph->room
|
||||
}
|
||||
// We used to just recreate the item if the underlying view model was swapped out e.g ph->room
|
||||
// but there is also a need to recreate items on room->room transitions (to re-make the
|
||||
// subviews), so just always recreate views for now.
|
||||
const isOldRoom = oldValue instanceof RoomTileViewModel;
|
||||
const isNewRoom = value instanceof RoomTileViewModel;
|
||||
return isOldRoom != isNewRoom;
|
||||
// subviews)
|
||||
// views can be recycled so if the room ID is different then also recreate
|
||||
if (oldValue.id !== value.id) {
|
||||
return true;
|
||||
}
|
||||
return false;
|
||||
}
|
||||
},
|
||||
tileVM => {
|
||||
|
|
Reference in a new issue