From 4474458f4bf4d765f360390cf26a882662358fa5 Mon Sep 17 00:00:00 2001
From: RMidhunSuresh <hi@midhun.dev>
Date: Mon, 23 May 2022 12:45:32 +0530
Subject: [PATCH] getActiveTheme should never return undefined

Instead it should throw an error.

This is useful for when we do setTheme(await getActiveTheme()) because
setTheme expects a string.
---
 src/platform/web/ThemeLoader.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/platform/web/ThemeLoader.ts b/src/platform/web/ThemeLoader.ts
index d9aaabb6..2aa79bb5 100644
--- a/src/platform/web/ThemeLoader.ts
+++ b/src/platform/web/ThemeLoader.ts
@@ -58,7 +58,7 @@ export class ThemeLoader {
         return Object.keys(this._themeMapping);
     }
 
-    async getActiveTheme(): Promise<string|undefined> {
+    async getActiveTheme(): Promise<string> {
         // check if theme is set via settings
         let theme = await this._platform.settingsStorage.getString("theme");
         if (theme) {
@@ -70,6 +70,6 @@ export class ThemeLoader {
         } else if (window.matchMedia("(prefers-color-scheme: light)").matches) {
             return this._platform.config["defaultTheme"].light;
         }
-        return undefined;
+        throw new Error("Cannot find active theme!");
     }
 }