mystiq/hydrogen-web
Archived
4
1
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #350 from vector-im/bwindels/linkify-parenthesis

Browse source 
Don't accept closing parenthesis as last character of url
This commit is contained in:
Bruno Windels 2021-05-12 20:50:39 +00:00 committed by GitHub
commit 41f77f33af
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/domain/session/room/timeline/linkify/linkify.js
View file

@ -96,6 +96,12 @@ export function tests() {
} }
}, },
"Link doesn't adopt closing parenthesis": assert => {
const link = "(https://matrix.org)";
const out = [{ type: "text", text: "(" }, { type: "link", text: "https://matrix.org" }, { type: "text", text: ")" }];
test(assert, link, out);
},
"Unicode in hostname must not linkify": assert => { "Unicode in hostname must not linkify": assert => {
const link = "https://foo.bar\uD83D\uDE03.com"; const link = "https://foo.bar\uD83D\uDE03.com";
const out = [{ type: "link", text: "https://foo.bar" }, const out = [{ type: "link", text: "https://foo.bar" },

2
src/domain/session/room/timeline/linkify/regex.js
View file

@ -4,7 +4,7 @@ meaning that any escapes (\) must also
be escaped. be escaped.
*/ */
const scheme = "(?:https|http|ftp):\\/\\/"; const scheme = "(?:https|http|ftp):\\/\\/";
const noSpaceNorPunctuation = "[^\\s.,?!]"; const noSpaceNorPunctuation = "[^\\s.,?!)]";
const hostCharacter = "[a-zA-Z0-9:.\\[\\]-]"; const hostCharacter = "[a-zA-Z0-9:.\\[\\]-]";
/* /*