mystiq/hydrogen-web
Archived
4
1
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity

throw when something tracked is not disposable, fail early

Browse source
This commit is contained in:
Bruno Windels 2020-10-09 17:01:54 +02:00
parent 1289f065d6
commit 3ab68ef438
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/utils/Disposables.js
View file

@ -22,6 +22,10 @@ function disposeValue(value) {
} }
} }
function isDisposable(value) {
return value && (typeof value === "function" || typeof value.dispose === "function");
}
export class Disposables { export class Disposables {
constructor() { constructor() {
this._disposables = []; this._disposables = [];
@ -31,6 +35,9 @@ export class Disposables {
if (this.isDisposed) { if (this.isDisposed) {
throw new Error("Already disposed, check isDisposed after await if needed"); throw new Error("Already disposed, check isDisposed after await if needed");
} }
if (!isDisposable(disposable)) {
throw new Error("Not a disposable");
}
this._disposables.push(disposable); this._disposables.push(disposable);
return disposable; return disposable;
} }