mystiq/dex
Archived
4
0
Fork 1
Code Issues Pull requests Packages Projects Releases Wiki Activity

Updated comment to include reference to GitHub Enterprise not supporting verified emails

Browse source
This commit is contained in:
Chien Huey 2017-08-18 11:46:05 -04:00
parent 98f6a217d3
commit 99370b5880
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
connector/github/github.go
View file

@ -503,7 +503,16 @@ func (c *githubConnector) userEmail(ctx context.Context, client *http.Client) (s
}
for _, email := range emails {
// if GitHub Enterprise, set email.Verified to true
/*
if GitHub Enterprise, set email.Verified to true
This change being made because GitHub Enterprise does not
support email verification. CircleCI indicated that GitHub
advised them not to check for verified emails
(https://circleci.com/enterprise/changelog/#1-47-1).
In addition, GitHub Enterprise support replied to a support
ticket with "There is no way to verify an email address in
GitHub Enterprise."
*/
if c.hostName != "" {
email.Verified = true
}