Merge pull request #7 from rithujohn191/ldap-password-check

connector/ldap: check for blank passwords and return error.
This commit is contained in:
rithu leena john 2017-05-01 17:06:55 -07:00 committed by GitHub
commit 10253725de

View file

@ -345,6 +345,11 @@ func (c *ldapConnector) userEntry(conn *ldap.Conn, username string) (user ldap.E
}
func (c *ldapConnector) Login(ctx context.Context, s connector.Scopes, username, password string) (ident connector.Identity, validPass bool, err error) {
// make this check to avoid anonymous bind to the LDAP server.
if password == "" {
return connector.Identity{}, false, nil
}
var (
// We want to return a different error if the user's password is incorrect vs
// if there was an error.