feat-protobuf #1
No reviewers
Labels
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: mCaptcha/dcache#1
Loading…
Reference in New Issue
No description provided.
Delete Branch "feat-protobuf"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR swaps out Actix-Web based JSON networking stack with tonic and protobuf. Protobuf implementation was bootstrapped from databend's metasrv package (Copyright 2023, Apache 2-0) with improvements for health monitoring.
metasrv
wraps JSON with protobuf, so this patch starts from there. Upon benchmarking, we realized that a pure protobuf implementation is 4x faster, so the JSON dependency was removed from the wire format.The in-memory implementation of dcache and the efficient wire format exposed a bottleneck in the critical section of libmCaptcha. A fix for this will be uploaded in a later PR.