gitea-mirror/tea
1
0
Fork 0
mirror of https://gitea.com/gitea/tea.git synced 2024-06-03 10:11:22 +05:30
Code Issues Packages Projects Releases Wiki Activity

implement code review suggestions

Browse source
This commit is contained in:
Norwin Roosen 2018-12-05 00:19:33 +01:00
parent 109e350a6e
commit 0748121726
2 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
cmd/issues.go
View file

@ -129,9 +129,8 @@ func initCommand(ctx *cli.Context) (*Login, string, string) {
log.Fatal("load config file failed", yamlConfigPath)
}
loginFlag := getGlobalFlag(ctx, "login")
var login *Login
if loginFlag == "" {
if loginFlag := getGlobalFlag(ctx, "login"); loginFlag == "" {
login, err = getActiveLogin()
if err != nil {
log.Fatal(err)

9
cmd/releases.go
View file

@ -99,7 +99,7 @@ var CmdReleaseCreate = cli.Command{
func runReleaseCreate(ctx *cli.Context) error {
login, owner, repo := initCommand(ctx)
_, err := login.Client().CreateRelease(owner, repo, gitea.CreateReleaseOption{
release, err := login.Client().CreateRelease(owner, repo, gitea.CreateReleaseOption{
TagName: ctx.String("tag"),
Target: ctx.String("target"),
Title: ctx.String("title"),
@ -114,17 +114,14 @@ func runReleaseCreate(ctx *cli.Context) error {
for _, asset := range ctx.StringSlice("asset") {
var file *os.File
file, err = os.Open(asset)
if err != nil {
if file, err = os.Open(asset); err != nil {
log.Fatal(err)
}
filePath := filepath.Base(asset)
_, err = login.Client().CreateReleaseAttachment(owner, repo, release.ID, file, filePath)
if err != nil {
if _, err = login.Client().CreateReleaseAttachment(owner, repo, release.ID, file, filePath); err != nil {
log.Fatal(err)
}
}