address comments

This commit is contained in:
pat-s 2023-12-12 15:00:04 +01:00
parent 415bdaa4a9
commit a9969002e2
No known key found for this signature in database
GPG key ID: 3C6318841EF78925

View file

@ -83,7 +83,7 @@ Yet most often no issues will be encountered and the chart maintainers aim to co
## Dependencies
Gitea is most performant when run with an external database and cache.
This chart provides those dependencies as sub-chart dependencies.
This chart provides those dependencies via sub-charts.
Users can also configure their own external providers via the configuration.
### HA Dependencies
@ -104,9 +104,9 @@ Alternatively, the following non-HA replacements are available:
Updates of sub-charts will be incorporated into the Gitea chart as they are released.
The reasoning behind this is that new users of the chart will start with the most recent sub-chart dependency versions.
If you want to stay on an older appVersion of a sub-chart dependency (e.g. PostgreSQL), you need to override the image tag in your `values.yaml` file.
**Note** If you want to stay on an older appVersion of a sub-chart dependency (e.g. PostgreSQL), you need to override the image tag in your `values.yaml` file.
In fact, we recommend to do so right from the start to be independent of major sub-chart dependency changes as they are released.
There is no need to update to every new PostgreSQL major version - you can happily skip some and do a larger update every few years.
There is no need to update to every new PostgreSQL major version - you can happily skip some and do larger updates when you are ready for them.
We recommend to use a rolling tag like `:<majorVersion>-debian-11` to incorporate minor and patch updates for the respective major version as they are released.
Alternatively you can also use a versioning helper tool like [renovate](https://github.com/renovatebot/renovate).
@ -114,7 +114,7 @@ Alternatively you can also use a versioning helper tool like [renovate](https://
Please double-check the image repository and available tags in the sub-chart:
- [PostgreSQL-HA](https://github.com/bitnami/charts/blob/main/bitnami/postgresql-ha/values.yaml#L106-L107)
- [Redis Cluster](https://github.com/bitnami/charts/blob/d6059e1cfa130e3f206976c412ee41c69532ed2f/bitnami/redis-cluster/values.yaml#L75-L76)
- [Redis Cluster](https://github.com/bitnami/charts/blob/main/bitnami/redis-cluster/values.yaml#L75-L76)
and look up the image tag which fits your needs on Dockerhub.
@ -1091,7 +1091,8 @@ If you miss this, blindly upgrading may delete your Postgres instance and you ma
- Update PostgreSQL sub-chart dependencies to appVersion 16.x
- Update to sub-charts versioning approach: Users are encouraged to pin the version tag of the sub-chart dependencies to a major appVersion.
This avoids issues during chart upgrades and allows to incorporate new sub-chart versions as they come in. Please see the new [README section describing the versioning approach for sub-chart versions](#dependency-versioning).
This avoids issues during chart upgrades and allows to incorporate new sub-chart versions as they are released.
Please see the new [README section describing the versioning approach for sub-chart versions](#dependency-versioning).
</details>