From fb7355a186ab78caa575c882a40a16830083638a Mon Sep 17 00:00:00 2001 From: 6543 <6543@noreply.gitea.io> Date: Mon, 11 May 2020 15:28:10 +0000 Subject: [PATCH] IssueUn-/Subscription take care of new 200 status (#325) IssueUn-/Subscription handle 200 status Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/325 Reviewed-by: Andrew Thornton Reviewed-by: lafriks --- gitea/issue_subscription.go | 6 ++++++ gitea/issue_subscription_test.go | 5 ++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/gitea/issue_subscription.go b/gitea/issue_subscription.go index f7670bf..b7980cf 100644 --- a/gitea/issue_subscription.go +++ b/gitea/issue_subscription.go @@ -30,6 +30,9 @@ func (c *Client) AddIssueSubscription(owner, repo string, index int64, user stri if status == http.StatusCreated { return nil } + if status == http.StatusOK { + return fmt.Errorf("already subscribed") + } return fmt.Errorf("unexpected Status: %d", status) } @@ -45,6 +48,9 @@ func (c *Client) DeleteIssueSubscription(owner, repo string, index int64, user s if status == http.StatusCreated { return nil } + if status == http.StatusOK { + return fmt.Errorf("already unsubscribed") + } return fmt.Errorf("unexpected Status: %d", status) } diff --git a/gitea/issue_subscription_test.go b/gitea/issue_subscription_test.go index 5ab4e52..fe8c56c 100644 --- a/gitea/issue_subscription_test.go +++ b/gitea/issue_subscription_test.go @@ -29,7 +29,10 @@ func TestIssueSubscription(t *testing.T) { assert.NoError(t, err) assert.True(t, wi.Subscribed) - assert.NoError(t, c.IssueSubscribe(repo.Owner.UserName, repo.Name, 1)) + err = c.IssueSubscribe(repo.Owner.UserName, repo.Name, 1) + if assert.Error(t, err) { + assert.EqualValues(t, "already subscribed", err.Error()) + } wi, err = c.CheckIssueSubscription(repo.Owner.UserName, repo.Name, 1) assert.NoError(t, err) assert.True(t, wi.Subscribed)