From a6cca9eec146aab2b2e7e92ba5e039d7bebc4e88 Mon Sep 17 00:00:00 2001 From: 6543 <6543@noreply.gitea.io> Date: Sat, 5 Sep 2020 06:27:44 +0000 Subject: [PATCH] Update ListMilestoneOption struct (#393) Update ListMilestoneOption struct Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/393 Reviewed-by: Lunny Xiao Reviewed-by: Andrew Thornton --- gitea/issue_milestone.go | 4 ++++ gitea/issue_milestone_test.go | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/gitea/issue_milestone.go b/gitea/issue_milestone.go index 1270925..ad91387 100644 --- a/gitea/issue_milestone.go +++ b/gitea/issue_milestone.go @@ -30,6 +30,7 @@ type ListMilestoneOption struct { ListOptions // open, closed, all State StateType + Name string } // QueryEncode turns options into querystring argument @@ -38,6 +39,9 @@ func (opt *ListMilestoneOption) QueryEncode() string { if opt.State != "" { query.Add("state", string(opt.State)) } + if len(opt.Name) != 0 { + query.Add("name", opt.Name) + } return query.Encode() } diff --git a/gitea/issue_milestone_test.go b/gitea/issue_milestone_test.go index 1c67427..5937bd8 100644 --- a/gitea/issue_milestone_test.go +++ b/gitea/issue_milestone_test.go @@ -49,6 +49,10 @@ func TestMilestones(t *testing.T) { ml, err = c.ListRepoMilestones(repo.Owner.UserName, repo.Name, ListMilestoneOption{State: StateAll}) assert.NoError(t, err) assert.Len(t, ml, 3) + ml, err = c.ListRepoMilestones(repo.Owner.UserName, repo.Name, ListMilestoneOption{State: StateAll, Name: "V3.0"}) + assert.NoError(t, err) + assert.Len(t, ml, 1) + assert.EqualValues(t, "v3.0", ml[0].Title) // GetMilestone _, err = c.GetMilestone(repo.Owner.UserName, repo.Name, m4.ID)