Conductor integration #9

New issue

Open

opened 2022-11-16 15:15:55 +05:30 by realaravinth · 3 comments

realaravinth commented

2022-11-16 15:15:55 +05:30

Owner

No description provided.

realaravinth self-assigned this 2022-11-16 15:15:55 +05:30

realaravinth started working 2022-11-16 15:16:49 +05:30

realaravinth commented

2022-11-16 15:44:07 +05:30

Author

Owner

To ensure max code reuse, I've refactored libconductor to ship a minimal event type only version using feature gates.

From libprepages/conductor:

Changes live in min-libconductor

Diff: 96cd918dfe..2e3d6999ff

Merged into libprepages/conductor's master.

To ensure max code reuse, I've refactored [`libconductor`](https://git.batsense.net/LibrePages/conductor/src/branch/master/env/libconductor) to ship a minimal event type only version using feature gates. --- From libprepages/conductor: Changes live in [`min-libconductor`](https://git.batsense.net/LibrePages/conductor/src/branch/min-libconductor) Diff: https://git.batsense.net/LibrePages/conductor/compare/96cd918dfe3faa2b9dbc1f44efe8ef3bd0aa271a..2e3d6999fff5cefc6fa2f51d544e5639da234754 Merged into libprepages/conductor's master.

realaravinth commented

2022-11-16 18:32:47 +05:30

Author

Owner

To setup integration testing, we'll have to run an instance of librepages/conductor in the CI. Therefore, conductor must be fully configurable via environment variables. 1fcded74c0 manually reads such environment variables.

To setup integration testing, we'll have to run an instance of librepages/conductor in the CI. Therefore, conductor must be fully configurable via environment variables. https://git.batsense.net/LibrePages/conductor/commit/1fcded74c0f453a462f68032b3aef9d8efdcfe1a manually reads such environment variables.

realaravinth stopped working 2022-11-16 18:36:17 +05:30

3 hours 19 minutes

realaravinth started working 2022-11-16 18:41:47 +05:30

realaravinth stopped working 2022-11-16 19:37:54 +05:30

56 minutes 7 seconds

realaravinth added spent time 2022-12-15 01:03:18 +05:30

5 hours 30 minutes

realaravinth commented

2022-12-15 01:05:21 +05:30

Author

Owner

Diff: 5c0f6fd84d...5350b22ffe

Summary:

Script to launch conductor instance while developing locally
Launch conductor instance in CI
Load and implement conductor integration
Relay notifications to conductor on site events

Diff: https://git.batsense.net/LibrePages/librepages/compare/5c0f6fd84dc60f7ad85f22b98ba143b47c7347e0...5350b22ffeae0e599ecd2eaf478ed048ebf71e50 ## Summary: 1. Script to launch conductor instance while developing locally 2. Launch conductor instance in CI 3. Load and implement conductor integration 4. Relay notifications to conductor on site events