From 40d1ab1cfaedd43ea62730c213e8582c65350221 Mon Sep 17 00:00:00 2001 From: Aravinth Manivannan Date: Sun, 1 Oct 2023 20:37:34 +0530 Subject: [PATCH] fix: count success if test doesnt fail --- common/logger.py | 1 + features/steps/object.py | 14 ++++---------- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/common/logger.py b/common/logger.py index 07f0502..135f76c 100644 --- a/common/logger.py +++ b/common/logger.py @@ -31,6 +31,7 @@ logger = configure_logger() def upload_logs_to_ftest(success: bool, logs: str): from .env import FTEST_HOST, FTEST_AUTH + parsed_ftest_host = urlparse(FTEST_HOST) ftest = urlunparse( ( diff --git a/features/steps/object.py b/features/steps/object.py index 1a08109..e73b07a 100644 --- a/features/steps/object.py +++ b/features/steps/object.py @@ -32,16 +32,8 @@ def get_fediverse_actor(context): @when("Receiving or querying an object") def check_actor_exists(context): - name = "check_actor_exists" - try: - actor = get_ap_obj(context.actor_url) - assert actor is not None - except Exception as e: - logger.error(e) - context.failure[name] = e - raise e - - context.success.append(name) + actor = get_ap_obj(context.actor_url) + assert actor is not None context.actor = actor @@ -70,6 +62,7 @@ def verify_id_resolves(context): logger.error(e) context.failure[name] = e raise e + context.success.append(name) @then("context must be ActivityPub") @@ -88,3 +81,4 @@ def ctx_is_ap(context): logger.error(e) context.failure[name] = e raise e + context.success.append(name)