From fc169af10f0b50f6de02892eb87140c7d889de2a Mon Sep 17 00:00:00 2001 From: RMidhunSuresh Date: Mon, 23 Aug 2021 16:09:40 +0530 Subject: [PATCH] Rename toggle to set Signed-off-by: RMidhunSuresh --- src/domain/login/LoginViewModel.js | 14 +++++++------- src/domain/login/PasswordLoginViewModel.js | 4 ++-- src/domain/login/StartSSOLoginViewModel.js | 4 ++-- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/domain/login/LoginViewModel.js b/src/domain/login/LoginViewModel.js index 832d2916..85dddb79 100644 --- a/src/domain/login/LoginViewModel.js +++ b/src/domain/login/LoginViewModel.js @@ -115,20 +115,20 @@ export class LoginViewModel extends ViewModel { this.emitChange("errorMessage"); } - _toggleBusy() { - this._isBusy = !this._isBusy; - this._passwordLoginViewModel?.toggleBusy(); - this._startSSOLoginViewModel?.toggleBusy(); + _setBusy(status) { + this._isBusy = status; + this._passwordLoginViewModel?.setBusy(status); + this._startSSOLoginViewModel?.setBusy(status); this.emitChange("isBusy"); } async attemptLogin(loginMethod) { - this._toggleBusy(); + this._setBusy(true); this._sessionContainer.startWithLogin(loginMethod); const loadStatus = this._sessionContainer.loadStatus; const handle = loadStatus.waitFor(status => status !== LoadStatus.Login); await handle.promise; - this._toggleBusy(); + this._setBusy(false); const status = loadStatus.get(); if (status === LoadStatus.LoginFailed) { return this._sessionContainer.loginFailure; @@ -163,7 +163,7 @@ export class LoginViewModel extends ViewModel { if (!this._loadViewModel.loading) { this._loadViewModelSubscription = this.disposeTracked(this._loadViewModelSubscription); } - this._toggleBusy(false); + this._setBusy(false); }) ); } diff --git a/src/domain/login/PasswordLoginViewModel.js b/src/domain/login/PasswordLoginViewModel.js index 7ba75c18..f8d354a4 100644 --- a/src/domain/login/PasswordLoginViewModel.js +++ b/src/domain/login/PasswordLoginViewModel.js @@ -30,8 +30,8 @@ export class PasswordLoginViewModel extends ViewModel { get isBusy() { return this._isBusy; } get errorMessage() { return this._errorMessage; } - toggleBusy() { - this._isBusy = !this._isBusy; + setBusy(status) { + this._isBusy = status; this.emitChange("isBusy"); } diff --git a/src/domain/login/StartSSOLoginViewModel.js b/src/domain/login/StartSSOLoginViewModel.js index bd236788..54218d22 100644 --- a/src/domain/login/StartSSOLoginViewModel.js +++ b/src/domain/login/StartSSOLoginViewModel.js @@ -25,8 +25,8 @@ export class StartSSOLoginViewModel extends ViewModel{ get isBusy() { return this._isBusy; } - toggleBusy() { - this._isBusy = !this._isBusy; + setBusy(status) { + this._isBusy = status; this.emitChange("isBusy"); }