From f0b6384ad78dc00a1836dcdd9ccc972245261b6a Mon Sep 17 00:00:00 2001 From: Danila Fedorin Date: Tue, 3 Aug 2021 13:27:33 -0700 Subject: [PATCH] Rename 'disabled' to 'interactive' in BaseMessageView --- .../web/ui/session/room/MessageComposer.js | 2 +- .../ui/session/room/timeline/BaseMessageView.js | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/platform/web/ui/session/room/MessageComposer.js b/src/platform/web/ui/session/room/MessageComposer.js index b28c51b0..20fd3659 100644 --- a/src/platform/web/ui/session/room/MessageComposer.js +++ b/src/platform/web/ui/session/room/MessageComposer.js @@ -45,7 +45,7 @@ export class MessageComposer extends TemplateView { className: "cancel", onClick: () => this._clearReplyingTo() }, "Close"), - t.view(new View(rvm, true, "div")) + t.view(new View(rvm, false, "div")) ]) }); const input = t.div({className: "MessageComposer_input"}, [ diff --git a/src/platform/web/ui/session/room/timeline/BaseMessageView.js b/src/platform/web/ui/session/room/timeline/BaseMessageView.js index a27e9bef..0fac7bc9 100644 --- a/src/platform/web/ui/session/room/timeline/BaseMessageView.js +++ b/src/platform/web/ui/session/room/timeline/BaseMessageView.js @@ -24,12 +24,12 @@ import {Menu} from "../../../general/Menu.js"; import {ReactionsView} from "./ReactionsView.js"; export class BaseMessageView extends TemplateView { - constructor(value, disabled = false, tagName = "li") { + constructor(value, interactive = true, tagName = "li") { super(value); this._menuPopup = null; this._tagName = tagName; // TODO An enum could be nice to make code easier to read at call sites. - this._disabled = disabled; + this._interactive = interactive; } render(t, vm) { @@ -38,13 +38,13 @@ export class BaseMessageView extends TemplateView { own: vm.isOwn, unsent: vm.isUnsent, unverified: vm.isUnverified, - disabled: this._disabled, + disabled: !this._interactive, continuation: vm => vm.isContinuation, }}, [ // dynamically added and removed nodes are handled below this.renderMessageBody(t, vm), // should be after body as it is overlayed on top - this._disabled ? [] : t.button({className: "Timeline_messageOptions"}, "⋯"), + this._interactive ? t.button({className: "Timeline_messageOptions"}, "⋯") : [], ]); // given that there can be many tiles, we don't add // unneeded DOM nodes in case of a continuation, and we add it @@ -52,10 +52,10 @@ export class BaseMessageView extends TemplateView { // as the avatar or sender doesn't need any bindings or event handlers. // don't use `t` from within the side-effect callback t.mapSideEffect(vm => vm.isContinuation, (isContinuation, wasContinuation) => { - if (isContinuation && !this._disabled && wasContinuation === false) { + if (isContinuation && this._interactive && wasContinuation === false) { li.removeChild(li.querySelector(".Timeline_messageAvatar")); li.removeChild(li.querySelector(".Timeline_messageSender")); - } else if (!isContinuation || this._disabled) { + } else if (!isContinuation || !this._interactive) { li.insertBefore(renderStaticAvatar(vm, 30, "Timeline_messageAvatar"), li.firstChild); li.insertBefore(tag.div({className: `Timeline_messageSender usercolor${vm.avatarColorNumber}`}, vm.displayName), li.firstChild); } @@ -64,7 +64,7 @@ export class BaseMessageView extends TemplateView { // but that adds a comment node to all messages without reactions let reactionsView = null; t.mapSideEffect(vm => vm.reactions, reactions => { - if (reactions && !this._disabled && !reactionsView) { + if (reactions && this._interactive && !reactionsView) { reactionsView = new ReactionsView(vm.reactions); this.addSubView(reactionsView); li.appendChild(mountView(reactionsView));