From e629a93edd74165290bd90811c2db1f18cabcfd0 Mon Sep 17 00:00:00 2001
From: Bruno Windels <brunow@element.io>
Date: Tue, 16 Feb 2021 17:45:19 +0100
Subject: [PATCH] delete extra log items when over limit,to not have to delete
 every flush

---
 src/logging/IDBLogger.js | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/logging/IDBLogger.js b/src/logging/IDBLogger.js
index 10e51f15..49c3e0a3 100644
--- a/src/logging/IDBLogger.js
+++ b/src/logging/IDBLogger.js
@@ -60,19 +60,20 @@ export class IDBLogger extends BaseLogger {
             for(const i of this._queuedItems) {
                 logs.add(i);
             }
-            // TODO: delete more than needed so we don't delete on every flush?
-            // trim logs if needed
             const itemCount = await reqAsPromise(logs.count());
             if (itemCount > this._limit) {
-                let currentCount = itemCount;
+                // delete an extra 10% so we don't need to delete every time we flush
+                let deleteAmount = (itemCount - this._limit) + Math.round(0.1 * this._limit);
                 await iterateCursor(logs.openCursor(), (_, __, cursor) => {
                     cursor.delete();
-                    currentCount -= 1;
-                    return {done: currentCount <= this._limit};
+                    deleteAmount -= 1;
+                    return {done: deleteAmount === 0};
                 });
             }
             await txnAsPromise(txn);
             this._queuedItems.splice(0, amount);
+        } catch (err) {
+            console.warn("Could not flush logs", err);
         } finally {
             try {
                 db.close();