From e105bc42370c611e5ffe9cfc5957dd78f919944d Mon Sep 17 00:00:00 2001 From: Bruno Windels Date: Tue, 24 Aug 2021 15:31:18 +0200 Subject: [PATCH] fix lint warnings --- src/domain/session/room/timeline/TilesCollection.js | 2 +- src/domain/session/room/timeline/TimelineViewModel.js | 4 ++-- src/domain/session/room/timeline/tiles/SimpleTile.js | 6 +++--- src/matrix/room/timeline/persistence/RelationWriter.js | 2 +- src/observable/map/MappedMap.js | 2 +- src/observable/map/ObservableMap.js | 2 +- src/platform/web/Platform.js | 2 +- src/platform/web/ui/general/ListView.js | 4 ++-- src/platform/web/ui/session/room/MessageComposer.js | 1 - src/platform/web/ui/session/room/RoomArchivedView.js | 4 ++-- .../web/ui/session/room/timeline/TextMessageView.js | 2 +- src/utils/EventEmitter.js | 4 ++-- 12 files changed, 17 insertions(+), 18 deletions(-) diff --git a/src/domain/session/room/timeline/TilesCollection.js b/src/domain/session/room/timeline/TilesCollection.js index 0acb2859..10062af2 100644 --- a/src/domain/session/room/timeline/TilesCollection.js +++ b/src/domain/session/room/timeline/TilesCollection.js @@ -219,7 +219,7 @@ export class TilesCollection extends BaseObservableList { } } - onMove(fromIdx, toIdx, value) { + onMove(/*fromIdx, toIdx, value*/) { // this ... cannot happen in the timeline? // perhaps we can use this event to support a local echo (in a different fragment) // to be moved to the key of the remote echo, so we don't loose state ... ? diff --git a/src/domain/session/room/timeline/TimelineViewModel.js b/src/domain/session/room/timeline/TimelineViewModel.js index 7b2765f5..a08ab060 100644 --- a/src/domain/session/room/timeline/TimelineViewModel.js +++ b/src/domain/session/room/timeline/TimelineViewModel.js @@ -59,7 +59,7 @@ export class TimelineViewModel extends ViewModel { } } - unloadAtTop(tileAmount) { + unloadAtTop(/*tileAmount*/) { // get lowerSortKey for tile at index tileAmount - 1 // tell timeline to unload till there (included given key) } @@ -68,7 +68,7 @@ export class TimelineViewModel extends ViewModel { } - unloadAtBottom(tileAmount) { + unloadAtBottom(/*tileAmount*/) { // get upperSortKey for tile at index tiles.length - tileAmount // tell timeline to unload till there (included given key) } diff --git a/src/domain/session/room/timeline/tiles/SimpleTile.js b/src/domain/session/room/timeline/tiles/SimpleTile.js index 68037a14..3c370b72 100644 --- a/src/domain/session/room/timeline/tiles/SimpleTile.js +++ b/src/domain/session/room/timeline/tiles/SimpleTile.js @@ -101,7 +101,7 @@ export class SimpleTile extends ViewModel { // return whether the tile should be removed // as SimpleTile only has one entry, the tile should be removed - removeEntry(entry) { + removeEntry(/*entry*/) { return true; } @@ -110,12 +110,12 @@ export class SimpleTile extends ViewModel { return false; } // let item know it has a new sibling - updatePreviousSibling(prev) { + updatePreviousSibling(/*prev*/) { } // let item know it has a new sibling - updateNextSibling(next) { + updateNextSibling(/*next*/) { } diff --git a/src/matrix/room/timeline/persistence/RelationWriter.js b/src/matrix/room/timeline/persistence/RelationWriter.js index 4944cc64..afc99e6d 100644 --- a/src/matrix/room/timeline/persistence/RelationWriter.js +++ b/src/matrix/room/timeline/persistence/RelationWriter.js @@ -147,7 +147,7 @@ export class RelationWriter { return true; } - _aggregateAnnotation(annotationEvent, targetStorageEntry, log) { + _aggregateAnnotation(annotationEvent, targetStorageEntry/*, log*/) { // TODO: do we want to verify it is a m.reaction event somehow? const relation = getRelation(annotationEvent); if (!relation) { diff --git a/src/observable/map/MappedMap.js b/src/observable/map/MappedMap.js index 47013df8..2a810058 100644 --- a/src/observable/map/MappedMap.js +++ b/src/observable/map/MappedMap.js @@ -42,7 +42,7 @@ export class MappedMap extends BaseObservableMap { this.emitAdd(key, mappedValue); } - onRemove(key, _value) { + onRemove(key/*, _value*/) { const mappedValue = this._mappedValues.get(key); if (this._mappedValues.delete(key)) { this.emitRemove(key, mappedValue); diff --git a/src/observable/map/ObservableMap.js b/src/observable/map/ObservableMap.js index b72cd039..8f5a0922 100644 --- a/src/observable/map/ObservableMap.js +++ b/src/observable/map/ObservableMap.js @@ -156,7 +156,7 @@ export function tests() { assert.equal(key, 1); assert.deepEqual(value, {value: 5}); }, - onUpdate(key, value, params) { + onUpdate(key, value/*, params*/) { update_fired += 1; assert.equal(key, 1); assert.deepEqual(value, {value: 7}); diff --git a/src/platform/web/Platform.js b/src/platform/web/Platform.js index 7e28f36f..40f47101 100644 --- a/src/platform/web/Platform.js +++ b/src/platform/web/Platform.js @@ -221,7 +221,7 @@ export class Platform { if (mimeType) { input.setAttribute("accept", mimeType); } - const promise = new Promise((resolve, reject) => { + const promise = new Promise(resolve => { const checkFile = () => { input.removeEventListener("change", checkFile, true); const file = input.files[0]; diff --git a/src/platform/web/ui/general/ListView.js b/src/platform/web/ui/general/ListView.js index 884eedc4..74aa9d87 100644 --- a/src/platform/web/ui/general/ListView.js +++ b/src/platform/web/ui/general/ListView.js @@ -121,7 +121,7 @@ export class ListView { this.onListChanged(); } - onRemove(idx, _value) { + onRemove(idx/*, _value*/) { this.onBeforeListChanged(); const [child] = this._childInstances.splice(idx, 1); child.root().remove(); @@ -129,7 +129,7 @@ export class ListView { this.onListChanged(); } - onMove(fromIdx, toIdx, value) { + onMove(fromIdx, toIdx/*, value*/) { this.onBeforeListChanged(); const [child] = this._childInstances.splice(fromIdx, 1); this._childInstances.splice(toIdx, 0, child); diff --git a/src/platform/web/ui/session/room/MessageComposer.js b/src/platform/web/ui/session/room/MessageComposer.js index e1d8f13c..c6e8a1ee 100644 --- a/src/platform/web/ui/session/room/MessageComposer.js +++ b/src/platform/web/ui/session/room/MessageComposer.js @@ -17,7 +17,6 @@ limitations under the License. import {TemplateView} from "../../general/TemplateView.js"; import {Popup} from "../../general/Popup.js"; import {Menu} from "../../general/Menu.js"; -import {TextMessageView} from "./timeline/TextMessageView.js"; import {viewClassForEntry} from "./TimelineList.js" export class MessageComposer extends TemplateView { diff --git a/src/platform/web/ui/session/room/RoomArchivedView.js b/src/platform/web/ui/session/room/RoomArchivedView.js index e5e489ed..80b18a08 100644 --- a/src/platform/web/ui/session/room/RoomArchivedView.js +++ b/src/platform/web/ui/session/room/RoomArchivedView.js @@ -17,7 +17,7 @@ limitations under the License. import {TemplateView} from "../../general/TemplateView.js"; export class RoomArchivedView extends TemplateView { - render(t, vm) { + render(t) { return t.div({className: "RoomArchivedView"}, t.h3(vm => vm.description)); } -} \ No newline at end of file +} diff --git a/src/platform/web/ui/session/room/timeline/TextMessageView.js b/src/platform/web/ui/session/room/timeline/TextMessageView.js index ef4d61d5..fcafaf27 100644 --- a/src/platform/web/ui/session/room/timeline/TextMessageView.js +++ b/src/platform/web/ui/session/room/timeline/TextMessageView.js @@ -97,7 +97,7 @@ const formatFunction = { link: linkPart => tag.a({href: linkPart.url, className: "link", target: "_blank", rel: "noopener" }, renderParts(linkPart.inlines)), pill: renderPill, format: formatPart => tag[formatPart.format](renderParts(formatPart.children)), - rule: rulePart => tag.hr(), + rule: () => tag.hr(), list: renderList, image: renderImage, newline: () => tag.br() diff --git a/src/utils/EventEmitter.js b/src/utils/EventEmitter.js index 2d2e4458..5dd56ac3 100644 --- a/src/utils/EventEmitter.js +++ b/src/utils/EventEmitter.js @@ -55,9 +55,9 @@ export class EventEmitter { } } - onFirstSubscriptionAdded(name) {} + onFirstSubscriptionAdded(/* name */) {} - onLastSubscriptionRemoved(name) {} + onLastSubscriptionRemoved(/* name */) {} } export function tests() {