diff --git a/src/domain/session/room/timeline/TilesCollection.js b/src/domain/session/room/timeline/TilesCollection.js index 33ae4472..54ab5ddd 100644 --- a/src/domain/session/room/timeline/TilesCollection.js +++ b/src/domain/session/room/timeline/TilesCollection.js @@ -150,7 +150,7 @@ export class TilesCollection extends BaseObservableList { const tileIdx = this._findTileIdx(entry); const tile = this._findTileAtIdx(entry, tileIdx); if (tile) { - const action = tile.updateEntry(entry, params, this._tileCreator); + const action = tile.updateEntry(entry, params); if (action.shouldReplace) { const newTile = this._tileCreator(entry); if (newTile) { diff --git a/src/domain/session/room/timeline/tiles/BaseMessageTile.js b/src/domain/session/room/timeline/tiles/BaseMessageTile.js index 7c5d7e1b..79e9ee12 100644 --- a/src/domain/session/room/timeline/tiles/BaseMessageTile.js +++ b/src/domain/session/room/timeline/tiles/BaseMessageTile.js @@ -110,8 +110,8 @@ export class BaseMessageTile extends SimpleTile { } } - updateEntry(entry, param, tileCreator) { - const action = super.updateEntry(entry, param, tileCreator); + updateEntry(entry, param) { + const action = super.updateEntry(entry, param); if (action.shouldUpdate) { this._updateReactions(); } diff --git a/src/domain/session/room/timeline/tiles/SimpleTile.js b/src/domain/session/room/timeline/tiles/SimpleTile.js index fabf7bf4..4b00c525 100644 --- a/src/domain/session/room/timeline/tiles/SimpleTile.js +++ b/src/domain/session/room/timeline/tiles/SimpleTile.js @@ -21,6 +21,7 @@ import {SendStatus} from "../../../../../matrix/room/sending/PendingEvent.js"; export class SimpleTile extends ViewModel { constructor(options) { super(options); + this._tileCreator = options.tileCreator; this._entry = options.entry; } // view model props for all subclasses @@ -96,13 +97,13 @@ export class SimpleTile extends ViewModel { } // update received for already included (falls within sort keys) entry - updateEntry(entry, param, tileCreator) { + updateEntry(entry, param) { const replyEntry = param?.reply ?? entry.contextEntry; if (replyEntry) { // this is an update to contextEntry used for replyPreview const action = this._replyTextTile?.updateEntry(replyEntry); if (action?.shouldReplace) { - this._replyTextTile = tileCreator(replyEntry); + this._replyTextTile = this._tileCreator(replyEntry); } } const renderedAsRedacted = this.shape === "redacted"; diff --git a/src/domain/session/room/timeline/tiles/TextTile.js b/src/domain/session/room/timeline/tiles/TextTile.js index 9c70dbfa..759bfc0d 100644 --- a/src/domain/session/room/timeline/tiles/TextTile.js +++ b/src/domain/session/room/timeline/tiles/TextTile.js @@ -22,7 +22,6 @@ export class TextTile extends BaseTextTile { constructor(options) { super(options); - this._tileCreator = options.tileCreator; this._replyTextTile = null; }