Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove forceRender

Browse source 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
This commit is contained in:
RMidhunSuresh 2021-08-11 12:37:07 +05:30 committed by Bruno Windels
parent e10b494f0c
commit da715c70b0
1 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/platform/web/ui/general/LazyListView.js
View file

@ -139,17 +139,12 @@ export class LazyListView extends ListView {
return new ItemRange(topCount, renderCount, bottomCount); return new ItemRange(topCount, renderCount, bottomCount);
} }
_renderIfNeeded(forceRender = false) { _renderIfNeeded() {
/*
forceRender only because we don't optimize onAdd/onRemove yet.
Ideally, onAdd/onRemove should only render whatever has changed + update padding + update renderRange
*/
const range = this._getVisibleRange(); const range = this._getVisibleRange();
const intersectRange = range.expand(this._overflowMargin); const intersectRange = range.expand(this._overflowMargin);
const renderRange = range.expand(this._overflowItems); const renderRange = range.expand(this._overflowItems);
// only update render Range if the new range + overflowMargin isn't contained by the old anymore // only update render Range if the new range + overflowMargin isn't contained by the old anymore
// or if we are force rendering if (!this._renderRange.contains(intersectRange)) {
if (forceRender || !this._renderRange.contains(intersectRange)) {
console.log("new", renderRange); console.log("new", renderRange);
console.log("current", this._renderRange); console.log("current", this._renderRange);
console.log("diff", this._renderRange.diff(renderRange)); console.log("diff", this._renderRange.diff(renderRange));