Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Projects Releases Packages Wiki Activity

don't reimplement removing an item from the list

Browse source
This commit is contained in:
Bruno Windels 2020-10-27 16:26:45 +01:00
parent 97c3a4b8f3
commit d55f38a9e9
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/platform/web/ui/general/ListView.js
View file

@ -147,17 +147,15 @@ export class ListView {
recreateItem(index, value) {
if (this._childInstances) {
const child = this._childCreator(value);
let oldChild;
if (child) {
oldChild = this._childInstances.splice(index, 1, child)[0];
this._root.replaceChild(child.mount(this._mountArgs), oldChild.root());
if (!child) {
this.onRemove(index, value);
} else {
oldChild = this._childInstances.splice(index, 1)[0];
oldChild.root().remove();
}
const [oldChild] = this._childInstances.splice(index, 1, child);
this._root.replaceChild(child.mount(this._mountArgs), oldChild.root());
oldChild.unmount();
}
}
}
onBeforeListChanged() {}
onListChanged() {}