From d3ea8c747ab41da9bbaea93a57bcfa7a42559e52 Mon Sep 17 00:00:00 2001
From: Bruno Windels <brunow@matrix.org>
Date: Fri, 21 Aug 2020 14:26:51 +0200
Subject: [PATCH] ignore own messages for unread state, and don't set unread
 while open

---
 src/matrix/room/Room.js        |  9 +++++++--
 src/matrix/room/RoomSummary.js | 25 +++++++++++++++++--------
 2 files changed, 24 insertions(+), 10 deletions(-)

diff --git a/src/matrix/room/Room.js b/src/matrix/room/Room.js
index d3f426a4..760b7f08 100644
--- a/src/matrix/room/Room.js
+++ b/src/matrix/room/Room.js
@@ -31,7 +31,7 @@ export class Room extends EventEmitter {
         this._roomId = roomId;
         this._storage = storage;
         this._hsApi = hsApi;
-		this._summary = new RoomSummary(roomId);
+		this._summary = new RoomSummary(roomId, user.id);
         this._fragmentIdComparer = new FragmentIdComparer([]);
 		this._syncWriter = new SyncWriter({roomId, fragmentIdComparer: this._fragmentIdComparer});
         this._emitCollectionChange = emitCollectionChange;
@@ -43,7 +43,12 @@ export class Room extends EventEmitter {
 
     /** @package */
     async writeSync(roomResponse, membership, isInitialSync, txn) {
-		const summaryChanges = this._summary.writeSync(roomResponse, membership, isInitialSync, txn);
+        const isTimelineOpen = !!this._timeline;
+		const summaryChanges = this._summary.writeSync(
+            roomResponse,
+            membership,
+            isInitialSync, isTimelineOpen,
+            txn);
 		const {entries, newLiveKey, changedMembers} = await this._syncWriter.writeSync(roomResponse, txn);
         let removedPendingEvents;
         if (roomResponse.timeline && roomResponse.timeline.events) {
diff --git a/src/matrix/room/RoomSummary.js b/src/matrix/room/RoomSummary.js
index 6d7361ee..5903b0e8 100644
--- a/src/matrix/room/RoomSummary.js
+++ b/src/matrix/room/RoomSummary.js
@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-function applySyncResponse(data, roomResponse, membership, isInitialSync) {
+function applySyncResponse(data, roomResponse, membership, isInitialSync, isTimelineOpen, ownUserId) {
     if (roomResponse.summary) {
         data = updateSummary(data, roomResponse.summary);
     }
@@ -25,7 +25,7 @@ function applySyncResponse(data, roomResponse, membership, isInitialSync) {
     // state comes before timeline
     if (roomResponse.state) {
         data = roomResponse.state.events.reduce((data, event) => {
-            return processEvent(data, event, isInitialSync);
+            return processEvent(data, event, isInitialSync, isTimelineOpen, ownUserId);
         }, data);
     }
     if (roomResponse.timeline) {
@@ -35,7 +35,7 @@ function applySyncResponse(data, roomResponse, membership, isInitialSync) {
             data.lastPaginationToken = timeline.prev_batch;
         }
         data = timeline.events.reduce((data, event) => {
-            return processEvent(data, event, isInitialSync);
+            return processEvent(data, event, isInitialSync, isTimelineOpen, ownUserId);
         }, data);
     }
     const unreadNotifications = roomResponse.unread_notifications;
@@ -48,7 +48,7 @@ function applySyncResponse(data, roomResponse, membership, isInitialSync) {
     return data;
 }
 
-function processEvent(data, event, isInitialSync) {
+function processEvent(data, event, isInitialSync, isTimelineOpen, ownUserId) {
     if (event.type === "m.room.encryption") {
         if (!data.isEncrypted) {
             data = data.cloneIfNeeded();
@@ -69,7 +69,7 @@ function processEvent(data, event, isInitialSync) {
     } else if (event.type === "m.room.message") {
         data = data.cloneIfNeeded();
         data.lastMessageTimestamp = event.origin_server_ts;
-        if (!isInitialSync) {
+        if (!isInitialSync && event.sender !== ownUserId && !isTimelineOpen) {
             data.isUnread = true;
         }
         const {content} = event;
@@ -145,7 +145,8 @@ class SummaryData {
 }
 
 export class RoomSummary {
-	constructor(roomId) {
+	constructor(roomId, ownUserId) {
+        this._ownUserId = ownUserId;
         this._data = new SummaryData(null, roomId);
 	}
 
@@ -169,6 +170,10 @@ export class RoomSummary {
         return this._data.isUnread;
     }
 
+    get notificationCount() {
+        return this._data.notificationCount;
+    }
+
 	get lastMessage() {
 		return this._data.lastMessageBody;
 	}
@@ -213,11 +218,15 @@ export class RoomSummary {
         return data;
     }
 
-	writeSync(roomResponse, membership, isInitialSync, txn) {
+	writeSync(roomResponse, membership, isInitialSync, isTimelineOpen, txn) {
         // clear cloned flag, so cloneIfNeeded makes a copy and
         // this._data is not modified if any field is changed.
         this._data.cloned = false;
-		const data = applySyncResponse(this._data, roomResponse, membership, isInitialSync);
+		const data = applySyncResponse(
+            this._data, roomResponse,
+            membership,
+            isInitialSync, isTimelineOpen,
+            this._ownUserId);
 		if (data !== this._data) {
             // need to think here how we want to persist
             // things like unread status (as read marker, or unread count)?